webrtc/api/peerconnection.cc - Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnection.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)

Patch Set: Also replace NDEBUG checks in taskrunner.h. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnection.cc

diff --git a/webrtc/api/peerconnection.cc b/webrtc/api/peerconnection.cc

index 1d85e73234349d515449284acdd9202800bd6f0e..9884ba4700e314ca245075afdece756a232210db 100644

--- a/webrtc/api/peerconnection.cc

+++ b/webrtc/api/peerconnection.cc

@@ -1944,7 +1944,7 @@ void PeerConnection::OnRemoteTrackRemoved(const std::string& stream_label,

stream->RemoveTrack(video_track);

}

} else {

- ASSERT(false && "Invalid media type");

+ RTC_DCHECK(false && "Invalid media type");

kwiberg-webrtc 2017/01/12 02:10:41 RTC_NOTREACHED with a message?

}