Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webrtc/p2p/quic/quictransportchannel.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)
Patch Set: Address final nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/quic/quictransport.cc ('k') | webrtc/pc/channelmanager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/quic/quictransportchannel.cc
diff --git a/webrtc/p2p/quic/quictransportchannel.cc b/webrtc/p2p/quic/quictransportchannel.cc
index da0531aa773b7329a2ad4decf8e507d2f78719f2..7241f1a0dc18ae81f29b68c4d7bbb362f1ca41cc 100644
--- a/webrtc/p2p/quic/quictransportchannel.cc
+++ b/webrtc/p2p/quic/quictransportchannel.cc
@@ -273,8 +273,8 @@ int QuicTransportChannel::SendPacket(const char* data,
// - Once the QUIC handshake completes, the state is that of the
// |channel_| again.
void QuicTransportChannel::OnWritableState(TransportChannel* channel) {
- ASSERT(rtc::Thread::Current() == network_thread_);
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(rtc::Thread::Current() == network_thread_);
+ RTC_DCHECK(channel == channel_.get());
LOG_J(LS_VERBOSE, this)
<< "QuicTransportChannel: channel writable state changed to "
<< channel_->writable();
@@ -307,8 +307,8 @@ void QuicTransportChannel::OnWritableState(TransportChannel* channel) {
}
void QuicTransportChannel::OnReceivingState(TransportChannel* channel) {
- ASSERT(rtc::Thread::Current() == network_thread_);
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(rtc::Thread::Current() == network_thread_);
+ RTC_DCHECK(channel == channel_.get());
LOG_J(LS_VERBOSE, this)
<< "QuicTransportChannel: channel receiving state changed to "
<< channel_->receiving();
@@ -323,9 +323,9 @@ void QuicTransportChannel::OnReadPacket(TransportChannel* channel,
size_t size,
const rtc::PacketTime& packet_time,
int flags) {
- ASSERT(rtc::Thread::Current() == network_thread_);
- ASSERT(channel == channel_.get());
- ASSERT(flags == 0);
+ RTC_DCHECK(rtc::Thread::Current() == network_thread_);
+ RTC_DCHECK(channel == channel_.get());
+ RTC_DCHECK(flags == 0);
switch (quic_state_) {
case QUIC_TRANSPORT_NEW:
@@ -360,7 +360,7 @@ void QuicTransportChannel::OnReadPacket(TransportChannel* channel,
void QuicTransportChannel::OnSentPacket(TransportChannel* channel,
const rtc::SentPacket& sent_packet) {
- ASSERT(rtc::Thread::Current() == network_thread_);
+ RTC_DCHECK(rtc::Thread::Current() == network_thread_);
SignalSentPacket(this, sent_packet);
}
@@ -371,24 +371,24 @@ void QuicTransportChannel::OnReadyToSend(TransportChannel* channel) {
}
void QuicTransportChannel::OnGatheringState(TransportChannelImpl* channel) {
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(channel == channel_.get());
SignalGatheringState(this);
}
void QuicTransportChannel::OnCandidateGathered(TransportChannelImpl* channel,
const Candidate& c) {
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(channel == channel_.get());
SignalCandidateGathered(this, c);
}
void QuicTransportChannel::OnRoleConflict(TransportChannelImpl* channel) {
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(channel == channel_.get());
SignalRoleConflict(this);
}
void QuicTransportChannel::OnRouteChange(TransportChannel* channel,
const Candidate& candidate) {
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(channel == channel_.get());
SignalRouteChange(this, candidate);
}
@@ -397,14 +397,14 @@ void QuicTransportChannel::OnSelectedCandidatePairChanged(
CandidatePairInterface* selected_candidate_pair,
int last_sent_packet_id,
bool ready_to_send) {
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(channel == channel_.get());
SignalSelectedCandidatePairChanged(this, selected_candidate_pair,
last_sent_packet_id, ready_to_send);
}
void QuicTransportChannel::OnChannelStateChanged(
TransportChannelImpl* channel) {
- ASSERT(channel == channel_.get());
+ RTC_DCHECK(channel == channel_.get());
SignalStateChanged(this);
}
@@ -506,7 +506,7 @@ bool QuicTransportChannel::StartQuicHandshake() {
}
bool QuicTransportChannel::HandleQuicPacket(const char* data, size_t size) {
- ASSERT(rtc::Thread::Current() == network_thread_);
+ RTC_DCHECK(rtc::Thread::Current() == network_thread_);
return quic_->OnReadPacket(data, size);
}
« no previous file with comments | « webrtc/p2p/quic/quictransport.cc ('k') | webrtc/pc/channelmanager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698