webrtc/modules/video_capture/windows/sink_filter_ds.cc - Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_capture/windows/sink_filter_ds.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)

Patch Set: Address final nits. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_capture/windows/sink_filter_ds.cc

diff --git a/webrtc/modules/video_capture/windows/sink_filter_ds.cc b/webrtc/modules/video_capture/windows/sink_filter_ds.cc

index 2f304ae65db78cfbe61ce08eec2e4c01465dbca6..1c5dd3afe08fa4cfcf5bc8bf508753fb9097e35c 100644

--- a/webrtc/modules/video_capture/windows/sink_filter_ds.cc

+++ b/webrtc/modules/video_capture/windows/sink_filter_ds.cc

@@ -10,6 +10,7 @@

#include "webrtc/modules/video_capture/windows/sink_filter_ds.h"

+#include "webrtc/base/checks.h"

#include "webrtc/base/platform_thread.h"

#include "webrtc/modules/video_capture/windows/help_functions_ds.h"

#include "webrtc/system_wrappers/include/trace.h"

@@ -337,7 +338,7 @@ CaptureInputPin::Receive ( IN IMediaSample * pIMediaSample )

if (SUCCEEDED (hr))

{

const LONG length = pIMediaSample->GetActualDataLength();

- ASSERT(length >= 0);

+ RTC_DCHECK(length >= 0);

unsigned char* pBuffer = NULL;

if(S_OK != pIMediaSample->GetPointer(&pBuffer))

« no previous file with comments | « webrtc/media/engine/fakewebrtcvoiceengine.h ('k') | webrtc/p2p/base/asyncstuntcpsocket.cc » ('j') | no next file with comments »