Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: webrtc/examples/peerconnection/client/main_wnd.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)
Patch Set: Address final nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/peerconnection/client/main_wnd.cc
diff --git a/webrtc/examples/peerconnection/client/main_wnd.cc b/webrtc/examples/peerconnection/client/main_wnd.cc
index 4830d29d156508695f030bc0df83992954abb64a..0f9e7b1f89a7b3fe099113525ce4ea958f4be6db 100644
--- a/webrtc/examples/peerconnection/client/main_wnd.cc
+++ b/webrtc/examples/peerconnection/client/main_wnd.cc
@@ -16,6 +16,7 @@
#include "webrtc/api/video/i420_buffer.h"
#include "webrtc/examples/peerconnection/client/defaults.h"
#include "webrtc/base/arraysize.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
@@ -79,11 +80,11 @@ MainWnd::MainWnd(const char* server, int port, bool auto_connect,
}
MainWnd::~MainWnd() {
- ASSERT(!IsWindow());
+ RTC_DCHECK(!IsWindow());
}
bool MainWnd::Create() {
- ASSERT(wnd_ == NULL);
+ RTC_DCHECK(wnd_ == NULL);
if (!RegisterWindowClass())
return false;
@@ -146,7 +147,7 @@ bool MainWnd::PreTranslateMessage(MSG* msg) {
}
void MainWnd::SwitchToConnectUI() {
- ASSERT(IsWindow());
+ RTC_DCHECK(IsWindow());
LayoutPeerListUI(false);
ui_ = CONNECT_TO_SERVER;
LayoutConnectUI(true);
@@ -440,7 +441,7 @@ bool MainWnd::RegisterWindowClass() {
wcex.lpfnWndProc = &WndProc;
wcex.lpszClassName = kClassName;
wnd_class_ = ::RegisterClassEx(&wcex);
- ASSERT(wnd_class_ != 0);
+ RTC_DCHECK(wnd_class_ != 0);
return wnd_class_ != 0;
}
@@ -456,7 +457,7 @@ void MainWnd::CreateChildWindow(HWND* wnd, MainWnd::ChildWindowID id,
100, 100, 100, 100, wnd_,
reinterpret_cast<HMENU>(id),
GetModuleHandle(NULL), NULL);
- ASSERT(::IsWindow(*wnd) != FALSE);
+ RTC_DCHECK(::IsWindow(*wnd) != FALSE);
::SendMessage(*wnd, WM_SETFONT, reinterpret_cast<WPARAM>(GetDefaultFont()),
TRUE);
}
@@ -614,7 +615,7 @@ void MainWnd::VideoRenderer::OnFrame(
SetSize(buffer->width(), buffer->height());
- ASSERT(image_.get() != NULL);
+ RTC_DCHECK(image_.get() != NULL);
libyuv::I420ToARGB(buffer->DataY(), buffer->StrideY(),
buffer->DataU(), buffer->StrideU(),
buffer->DataV(), buffer->StrideV(),

Powered by Google App Engine
This is Rietveld 408576698