Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: webrtc/base/win32socketserver.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)
Patch Set: Address final nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/win32filesystem.cc ('k') | webrtc/base/win32window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/win32socketserver.cc
diff --git a/webrtc/base/win32socketserver.cc b/webrtc/base/win32socketserver.cc
index 342cc3f0e5446f260146498b3418210bcf8a2e3f..d473a9cb734ac99741a7e9750006a5ecf2def432 100644
--- a/webrtc/base/win32socketserver.cc
+++ b/webrtc/base/win32socketserver.cc
@@ -251,11 +251,11 @@ bool Win32Socket::CreateT(int family, int type) {
}
int Win32Socket::Attach(SOCKET s) {
- ASSERT(socket_ == INVALID_SOCKET);
+ RTC_DCHECK(socket_ == INVALID_SOCKET);
if (socket_ != INVALID_SOCKET)
return SOCKET_ERROR;
- ASSERT(s != INVALID_SOCKET);
+ RTC_DCHECK(s != INVALID_SOCKET);
if (s == INVALID_SOCKET)
return SOCKET_ERROR;
@@ -304,7 +304,7 @@ SocketAddress Win32Socket::GetRemoteAddress() const {
}
int Win32Socket::Bind(const SocketAddress& addr) {
- ASSERT(socket_ != INVALID_SOCKET);
+ RTC_DCHECK(socket_ != INVALID_SOCKET);
if (socket_ == INVALID_SOCKET)
return SOCKET_ERROR;
@@ -553,7 +553,7 @@ int Win32Socket::EstimateMTU(uint16_t* mtu) {
}
void Win32Socket::CreateSink() {
- ASSERT(NULL == sink_);
+ RTC_DCHECK(NULL == sink_);
// Create window
sink_ = new EventSink(this);
@@ -563,7 +563,7 @@ void Win32Socket::CreateSink() {
bool Win32Socket::SetAsync(int events) {
if (NULL == sink_) {
CreateSink();
- ASSERT(NULL != sink_);
+ RTC_DCHECK(NULL != sink_);
}
// start the async select
@@ -793,7 +793,7 @@ bool Win32SocketServer::Wait(int cms, bool process_io) {
} while (b && TimeSince(start) < cms);
} else if (cms != 0) {
// Sit and wait forever for a WakeUp. This is the Thread::Send case.
- ASSERT(cms == -1);
+ RTC_DCHECK(cms == -1);
MSG msg;
b = GetMessage(&msg, NULL, s_wm_wakeup_id, s_wm_wakeup_id);
{
« no previous file with comments | « webrtc/base/win32filesystem.cc ('k') | webrtc/base/win32window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698