Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: webrtc/base/sslsocketfactory.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)
Patch Set: Address final nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/sslidentity.cc ('k') | webrtc/base/stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sslsocketfactory.cc
diff --git a/webrtc/base/sslsocketfactory.cc b/webrtc/base/sslsocketfactory.cc
index 7ab58fd04c6f53177bd1c47a2c66e439e0e93559..01d7d8145720e6da37d042276af849ae56b41f40 100644
--- a/webrtc/base/sslsocketfactory.cc
+++ b/webrtc/base/sslsocketfactory.cc
@@ -11,6 +11,7 @@
#include <memory>
#include "webrtc/base/autodetectproxy.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/httpcommon.h"
#include "webrtc/base/httpcommon-inl.h"
#include "webrtc/base/socketadapters.h"
@@ -37,8 +38,8 @@ class ProxySocketAdapter : public AsyncSocketAdapter {
}
int Connect(const SocketAddress& addr) override {
- ASSERT(NULL == detect_);
- ASSERT(NULL == socket_);
+ RTC_DCHECK(NULL == detect_);
+ RTC_DCHECK(NULL == socket_);
remote_ = addr;
if (remote_.IsAnyIP() && remote_.hostname().empty()) {
LOG_F(LS_ERROR) << "Empty address";
@@ -78,7 +79,7 @@ class ProxySocketAdapter : public AsyncSocketAdapter {
private:
// AutoDetectProxy Slots
void OnProxyDetectionComplete(SignalThread* thread) {
- ASSERT(detect_ == thread);
+ RTC_DCHECK(detect_ == thread);
Attach(factory_->CreateProxySocket(detect_->proxy(), family_, type_));
detect_->Release();
detect_ = NULL;
« no previous file with comments | « webrtc/base/sslidentity.cc ('k') | webrtc/base/stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698