Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: webrtc/base/socketadapters.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)
Patch Set: Address final nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/signalthread.cc ('k') | webrtc/base/socketaddress.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/socketadapters.cc
diff --git a/webrtc/base/socketadapters.cc b/webrtc/base/socketadapters.cc
index 0697c6fd518b4a8bca21638325f7a0f255788eb9..67debb60c10e21dbc19a97b6a27e9e3b542a54bc 100644
--- a/webrtc/base/socketadapters.cc
+++ b/webrtc/base/socketadapters.cc
@@ -97,7 +97,7 @@ void BufferedReadAdapter::BufferInput(bool on) {
}
void BufferedReadAdapter::OnReadEvent(AsyncSocket * socket) {
- ASSERT(socket == socket_);
+ RTC_DCHECK(socket == socket_);
if (!buffering_) {
AsyncSocketAdapter::OnReadEvent(socket);
@@ -184,7 +184,7 @@ int AsyncSSLSocket::Connect(const SocketAddress& addr) {
}
void AsyncSSLSocket::OnConnectEvent(AsyncSocket * socket) {
- ASSERT(socket == socket_);
+ RTC_DCHECK(socket == socket_);
// TODO: we could buffer output too...
VERIFY(sizeof(kSslClientHello) ==
DirectSend(kSslClientHello, sizeof(kSslClientHello)));
@@ -234,7 +234,7 @@ void AsyncSSLServerSocket::ProcessInput(char* data, size_t* len) {
*len -= sizeof(kSslClientHello);
// Clients should not send more data until the handshake is completed.
- ASSERT(*len == 0);
+ RTC_DCHECK(*len == 0);
// Send a server hello back to the client.
DirectSend(kSslServerHello, sizeof(kSslServerHello));
@@ -557,7 +557,7 @@ void AsyncSocksProxySocket::OnConnectEvent(AsyncSocket* socket) {
}
void AsyncSocksProxySocket::ProcessInput(char* data, size_t* len) {
- ASSERT(state_ < SS_TUNNEL);
+ RTC_DCHECK(state_ < SS_TUNNEL);
ByteBufferReader response(data, *len);
@@ -715,7 +715,7 @@ AsyncSocksProxyServerSocket::AsyncSocksProxyServerSocket(AsyncSocket* socket)
void AsyncSocksProxyServerSocket::ProcessInput(char* data, size_t* len) {
// TODO: See if the whole message has arrived
- ASSERT(state_ < SS_CONNECT_PENDING);
+ RTC_DCHECK(state_ < SS_CONNECT_PENDING);
ByteBufferReader response(data, *len);
if (state_ == SS_HELLO) {
« no previous file with comments | « webrtc/base/signalthread.cc ('k') | webrtc/base/socketaddress.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698