Replace ASSERT by RTC_DCHECK in all non-test code.

webrtc/base/rollingaccumulator.h

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_ROLLINGACCUMULATOR_H_
 #define WEBRTC_BASE_ROLLINGACCUMULATOR_H_
 
 #include <algorithm>
 #include <vector>
 
+#include "webrtc/base/checks.h"
 #include "webrtc/base/common.h"
 #include "webrtc/base/constructormagic.h"
 
 namespace rtc {
 
 // RollingAccumulator stores and reports statistics
 // over N most recent samples.
 //
 // T is assumed to be an int, long, double or float.
 template<typename T>
@@ skipping 63 matching lines @@
 
   double ComputeMean() const {
     if (count_ == 0) {
       return 0.0;
     }
     return sum_ / count_;
   }
 
   T ComputeMax() const {
     if (max_stale_) {
-      ASSERT(count_ > 0 &&
-          "It shouldn't be possible for max_stale_ && count_ == 0");
+      RTC_DCHECK(count_ > 0 &&
+                 "It shouldn't be possible for max_stale_ && count_ == 0");

[kwiberg-webrtc, 2017/01/12 02:10:41]

Remove the message, or use << on the DCHECK.

[nisse-webrtc, 2017/01/12 10:53:24]

Done. Two occurrences.

       max_ = samples_[next_index_];
       for (size_t i = 1u; i < count_; i++) {
         max_ = std::max(max_, samples_[(next_index_ + i) % max_count()]);
       }
       max_stale_ = false;
     }
     return max_;
   }
 
   T ComputeMin() const {
     if (min_stale_) {
-      ASSERT(count_ > 0 &&
-          "It shouldn't be possible for min_stale_ && count_ == 0");
+      RTC_DCHECK(count_ > 0 &&
+                 "It shouldn't be possible for min_stale_ && count_ == 0");

[kwiberg-webrtc, 2017/01/12 02:10:41]

Ditto.

       min_ = samples_[next_index_];
       for (size_t i = 1u; i < count_; i++) {
         min_ = std::min(min_, samples_[(next_index_ + i) % max_count()]);
       }
       min_stale_ = false;
     }
     return min_;
   }
 
   // O(n) time complexity.
@@ skipping 40 matching lines @@
   mutable T min_;
   mutable bool min_stale_;
   std::vector<T> samples_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(RollingAccumulator);
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_ROLLINGACCUMULATOR_H_