Replace ASSERT by RTC_DCHECK in all non-test code.

webrtc/base/socketpool.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 133 matching lines @@
 
 //////////////////////////////////////////////////////////////////////
 // ReuseSocketPool
 //////////////////////////////////////////////////////////////////////
 
 ReuseSocketPool::ReuseSocketPool(SocketFactory* factory)
 : factory_(factory), stream_(NULL), checked_out_(false) {
 }
 
 ReuseSocketPool::~ReuseSocketPool() {
-  ASSERT(!checked_out_);
+  RTC_DCHECK(!checked_out_);
   delete stream_;
 }
 
 StreamInterface*
 ReuseSocketPool::RequestConnectedStream(const SocketAddress& remote, int* err) {
   // Only one socket can be used from this "pool" at a time
-  ASSERT(!checked_out_);
+  RTC_DCHECK(!checked_out_);
   if (!stream_) {
     LOG_F(LS_VERBOSE) << "Creating new socket";
     int family = remote.family();
     // TODO: Deal with this when we/I clean up DNS resolution.
     if (remote.IsUnresolvedIP()) {
       family = AF_INET;
     }
     AsyncSocket* socket =
         factory_->CreateAsyncSocket(family, SOCK_STREAM);
     if (!socket) {
@@ skipping 19 matching lines @@
   }
   stream_->SignalEvent.disconnect(this);
   checked_out_ = true;
   if (err)
     *err = 0;
   return stream_;
 }
 
 void
 ReuseSocketPool::ReturnConnectedStream(StreamInterface* stream) {
-  ASSERT(stream == stream_);
-  ASSERT(checked_out_);
+  RTC_DCHECK(stream == stream_);
+  RTC_DCHECK(checked_out_);
   checked_out_ = false;
   // Until the socket is reused, monitor it to determine if it closes.
   stream_->SignalEvent.connect(this, &ReuseSocketPool::OnStreamEvent);
 }
 
 void
 ReuseSocketPool::OnStreamEvent(StreamInterface* stream, int events, int err) {
-  ASSERT(stream == stream_);
-  ASSERT(!checked_out_);
+  RTC_DCHECK(stream == stream_);
+  RTC_DCHECK(!checked_out_);
 
   // If the stream was written to and then immediately returned to us then
   // we may get a writable notification for it, which we should ignore.
   if (events == SE_WRITE) {
     LOG_F(LS_VERBOSE) << "Pooled Socket unexpectedly writable: ignoring";
     return;
   }
 
   // If the peer sent data, we can't process it, so drop the connection.
   // If the socket has closed, clean it up.
   // In either case, we'll reconnect it the next time it is used.
-  ASSERT(0 != (events & (SE_READ|SE_CLOSE)));
+  RTC_DCHECK(0 != (events & (SE_READ | SE_CLOSE)));
   if (0 != (events & SE_CLOSE)) {
     LOG_F(LS_VERBOSE) << "Connection closed with error: " << err;
   } else {
     LOG_F(LS_VERBOSE) << "Pooled Socket unexpectedly readable: closing";
   }
   stream_->Close();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // LoggingPoolAdapter - Adapts a StreamPool to supply streams with attached
 // LoggingAdapters.
 ///////////////////////////////////////////////////////////////////////////////
 
 LoggingPoolAdapter::LoggingPoolAdapter(
     StreamPool* pool, LoggingSeverity level, const std::string& label,
     bool binary_mode)
   : pool_(pool), level_(level), label_(label), binary_mode_(binary_mode) {
 }
 
 LoggingPoolAdapter::~LoggingPoolAdapter() {
   for (StreamList::iterator it = recycle_bin_.begin();
        it != recycle_bin_.end(); ++it) {
     delete *it;
   }
 }
 
 StreamInterface* LoggingPoolAdapter::RequestConnectedStream(
     const SocketAddress& remote, int* err) {
   if (StreamInterface* stream = pool_->RequestConnectedStream(remote, err)) {
-    ASSERT(SS_CLOSED != stream->GetState());
+    RTC_DCHECK(SS_CLOSED != stream->GetState());
     std::stringstream ss;
     ss << label_ << "(0x" << std::setfill('0') << std::hex << std::setw(8)
        << stream << ")";
     LOG_V(level_) << ss.str()
                   << ((SS_OPEN == stream->GetState()) ? " Connected"
                                                       : " Connecting")
                   << " to " << remote;
     if (recycle_bin_.empty()) {
       return new LoggingAdapter(stream, level_, ss.str(), binary_mode_);
     }
     LoggingAdapter* logging = recycle_bin_.front();
     recycle_bin_.pop_front();
     logging->set_label(ss.str());
     logging->Attach(stream);
     return logging;
   }
   return NULL;
 }
 
 void LoggingPoolAdapter::ReturnConnectedStream(StreamInterface* stream) {
   LoggingAdapter* logging = static_cast<LoggingAdapter*>(stream);
   pool_->ReturnConnectedStream(logging->Detach());
   recycle_bin_.push_back(logging);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 } // namespace rtc