Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Side by Side Diff: webrtc/api/peerconnection.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)
Patch Set: Address final nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/notifier.h ('k') | webrtc/api/peerconnectionfactory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 2054 matching lines...) Expand 10 before | Expand all | Expand 10 after
2065 // VideoRtpReceiver::track(). 2065 // VideoRtpReceiver::track().
2066 DestroyReceiver(track_id); 2066 DestroyReceiver(track_id);
2067 rtc::scoped_refptr<VideoTrackInterface> video_track = 2067 rtc::scoped_refptr<VideoTrackInterface> video_track =
2068 stream->FindVideoTrack(track_id); 2068 stream->FindVideoTrack(track_id);
2069 if (video_track) { 2069 if (video_track) {
2070 // There's no guarantee the track is still available, e.g. the track may 2070 // There's no guarantee the track is still available, e.g. the track may
2071 // have been removed from the stream by an application. 2071 // have been removed from the stream by an application.
2072 stream->RemoveTrack(video_track); 2072 stream->RemoveTrack(video_track);
2073 } 2073 }
2074 } else { 2074 } else {
2075 ASSERT(false && "Invalid media type"); 2075 RTC_NOTREACHED() << "Invalid media type";
2076 } 2076 }
2077 } 2077 }
2078 2078
2079 void PeerConnection::UpdateEndedRemoteMediaStreams() { 2079 void PeerConnection::UpdateEndedRemoteMediaStreams() {
2080 std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams_to_remove; 2080 std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams_to_remove;
2081 for (size_t i = 0; i < remote_streams_->count(); ++i) { 2081 for (size_t i = 0; i < remote_streams_->count(); ++i) {
2082 MediaStreamInterface* stream = remote_streams_->at(i); 2082 MediaStreamInterface* stream = remote_streams_->at(i);
2083 if (stream->GetAudioTracks().empty() && stream->GetVideoTracks().empty()) { 2083 if (stream->GetAudioTracks().empty() && stream->GetVideoTracks().empty()) {
2084 streams_to_remove.push_back(stream); 2084 streams_to_remove.push_back(stream);
2085 } 2085 }
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
2564 2564
2565 bool PeerConnection::StartRtcEventLog_w(rtc::PlatformFile file, 2565 bool PeerConnection::StartRtcEventLog_w(rtc::PlatformFile file,
2566 int64_t max_size_bytes) { 2566 int64_t max_size_bytes) {
2567 return event_log_->StartLogging(file, max_size_bytes); 2567 return event_log_->StartLogging(file, max_size_bytes);
2568 } 2568 }
2569 2569
2570 void PeerConnection::StopRtcEventLog_w() { 2570 void PeerConnection::StopRtcEventLog_w() {
2571 event_log_->StopLogging(); 2571 event_log_->StopLogging();
2572 } 2572 }
2573 } // namespace webrtc 2573 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/notifier.h ('k') | webrtc/api/peerconnectionfactory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698