Ensure internal_source is false for internal encoders.

webrtc/media/engine/webrtcvideoengine2.cc

Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index 129eb3288a6a27b03c5806eec76a4f4680d9319a..fdbb76ff22b835c84dec0b4261e4652e057deb8a 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -1768,6 +1768,8 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec(
             .value_or(webrtc::kVideoCodecUnknown);
     parameters_.config.encoder_settings.internal_source =
         external_encoder_factory_->EncoderTypeHasInternalSource(type);
+  } else {
+    parameters_.config.encoder_settings.internal_source = false;

[nisse-chromium (ooo August 14), 2017/01/09 08:27:41]

Does this function now set *all* attributes of
parameters_.config.encoder_settings?

[noahric, 2017/01/09 17:22:07]

I'm not sure, but that's probably a good question for mflodman@ or team to take
a pass over this code. I'd assume a safer pattern is to do something like
parameters_.config.<stuff> = {0} at the start of this function.

   }
   parameters_.config.rtp.ulpfec = codec_settings.ulpfec;
   parameters_.config.rtp.flexfec.flexfec_payload_type =