Do not send redundant selectionchange-events (decouple focus)

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 68 matching lines @@
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/ThreadableLoader.h"
 #include "core/page/Page.h"
 #include "core/page/ScopedPageSuspender.h"
 #include "core/paint/PaintLayer.h"
 #include "core/testing/NullExecutionContext.h"
 #include "modules/mediastream/MediaStream.h"
 #include "modules/mediastream/MediaStreamRegistry.h"
 #include "platform/Cursor.h"
 #include "platform/DragImage.h"
+#include "platform/KeyboardCodes.h"
 #include "platform/PlatformResourceLoader.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/loader/fetch/FetchParameters.h"
 #include "platform/loader/fetch/MemoryCache.h"
 #include "platform/loader/fetch/ResourceError.h"
 #include "platform/loader/fetch/ResourceFetcher.h"
 #include "platform/scroll/Scrollbar.h"
 #include "platform/scroll/ScrollbarTestSuite.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "platform/scroll/ScrollbarThemeMock.h"
 #include "platform/scroll/ScrollbarThemeOverlayMock.h"
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "platform/weborigin/KURLHash.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "platform/wtf/Forward.h"
 #include "platform/wtf/PtrUtil.h"
 #include "platform/wtf/dtoa/utils.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCache.h"
 #include "public/platform/WebCachePolicy.h"
 #include "public/platform/WebClipboard.h"
 #include "public/platform/WebFloatRect.h"
+#include "public/platform/WebKeyboardEvent.h"
 #include "public/platform/WebMockClipboard.h"
 #include "public/platform/WebSecurityOrigin.h"
 #include "public/platform/WebThread.h"
 #include "public/platform/WebURL.h"
 #include "public/platform/WebURLLoaderClient.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/platform/WebURLResponse.h"
 #include "public/web/WebConsoleMessage.h"
 #include "public/web/WebContextMenuData.h"
 #include "public/web/WebDataSource.h"
@@ skipping 4234 matching lines @@
   web_view_helper.InitializeAndLoad(
       base_url_ + "iframe_clear_focused_node_test.html", true);
 
   // Clear the focused node.
   web_view_helper.WebView()->ClearFocusedElement();
 
   // Now retrieve the FocusedNode and test it should be null.
   EXPECT_EQ(0, web_view_helper.WebView()->FocusedElement());
 }
 
+class ChangedSelectionCounter : public FrameTestHelpers::TestWebFrameClient {
+ public:
+  ChangedSelectionCounter() : call_count_(0) {}
+  void DidChangeSelection(bool isSelectionEmpty) { ++call_count_; }
+  int Count() const { return call_count_; }
+  void Reset() { call_count_ = 0; }
+
+ private:
+  int call_count_;
+};
+
+TEST_P(ParameterizedWebFrameTest, TabKeyCursorMoveTriggersOneSelectionChange) {
+  ChangedSelectionCounter counter;
+  FrameTestHelpers::WebViewHelper web_view_helper;
+  RegisterMockedHttpURLLoad("editable_elements.html");
+  WebViewImpl* web_view = web_view_helper.InitializeAndLoad(
+      base_url_ + "editable_elements.html", true, &counter);
+
+  WebKeyboardEvent tab_down(WebInputEvent::kKeyDown,
+                            WebInputEvent::kNoModifiers,
+                            WebInputEvent::kTimeStampForTesting);
+  WebKeyboardEvent tab_up(WebInputEvent::kKeyUp, WebInputEvent::kNoModifiers,
+                          WebInputEvent::kTimeStampForTesting);
+  tab_down.dom_key = Platform::Current()->DomKeyEnumFromString("\t");
+  tab_up.dom_key = Platform::Current()->DomKeyEnumFromString("\t");
+  tab_down.windows_key_code = VKEY_TAB;
+  tab_up.windows_key_code = VKEY_TAB;
+
+  // Move to the next text-field: 1 cursor change.
+  counter.Reset();
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_down));
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_up));
+  EXPECT_EQ(1, counter.Count());
+
+  // Move to another text-field: 1 cursor change.
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_down));
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_up));
+  EXPECT_EQ(2, counter.Count());
+
+  // Move to a number-field: 1 cursor change.
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_down));
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_up));
+  EXPECT_EQ(3, counter.Count());
+
+  // Move to an editable element: 1 cursor change.
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_down));
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_up));
+  EXPECT_EQ(4, counter.Count());
+
+  // Move to a non-editable element: 0 cursor changes.
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_down));
+  web_view->HandleInputEvent(WebCoalescedInputEvent(tab_up));
+  EXPECT_EQ(4, counter.Count());
+}
+
 // Implementation of WebFrameClient that tracks the v8 contexts that are created
 // and destroyed for verification.
 class ContextLifetimeTestWebFrameClient
     : public FrameTestHelpers::TestWebFrameClient {
  public:
   struct Notification {
    public:
     Notification(WebLocalFrame* frame,
                  v8::Local<v8::Context> context,
                  int world_id)
@@ skipping 7562 matching lines @@
 
   // Failing the original child frame navigation and trying to render fallback
   // content shouldn't crash. It should return NoLoadInProgress. This is so the
   // caller won't attempt to replace the correctly empty frame with an error
   // page.
   EXPECT_EQ(WebLocalFrame::NoLoadInProgress,
             child->MaybeRenderFallbackContent(WebURLError()));
 }
 
 }  // namespace blink