webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc - Issue 2616343003: Refactor TransportFeedback ensuring it's consistency:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc

Issue 2616343003: Refactor TransportFeedback ensuring it's consistency: (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc

index 1d42ad1b5dc813c4a4085fd595d1cb1194b08ab8..b351e103533dc948f49440604b8d285be750a414 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc

@@ -371,8 +371,8 @@ TEST(RtcpPacketTest, TransportFeedback_Limits) {

packet->SetBase(0, 0);

EXPECT_TRUE(packet->AddReceivedPacket(0x0, 0));

EXPECT_TRUE(packet->AddReceivedPacket(0x8000, 1000));

- EXPECT_TRUE(packet->AddReceivedPacket(0xFFFF, 2000));

danilchap 2017/01/11 17:11:57 ([0, 0xffff] has size 0x10000 which exceed maximum

- EXPECT_FALSE(packet->AddReceivedPacket(0, 3000));

+ EXPECT_TRUE(packet->AddReceivedPacket(0xFFFE, 2000));

+ EXPECT_FALSE(packet->AddReceivedPacket(0xFFFF, 3000));

// Too large delta.

packet.reset(new TransportFeedback());

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc ('k') | no next file » | no next file with comments »