Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: webrtc/p2p/base/transportcontroller.h

Issue 2614263002: Remove BaseChannel's dependency on TransportController. (Closed)
Patch Set: Fix the channel_unittests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 bool RemoveRemoteCandidates(const Candidates& candidates, std::string* err); 106 bool RemoveRemoteCandidates(const Candidates& candidates, std::string* err);
107 bool ReadyForRemoteCandidates(const std::string& transport_name) const; 107 bool ReadyForRemoteCandidates(const std::string& transport_name) const;
108 // TODO(deadbeef): GetStats isn't const because all the way down to 108 // TODO(deadbeef): GetStats isn't const because all the way down to
109 // OpenSSLStreamAdapter, 109 // OpenSSLStreamAdapter,
110 // GetSslCipherSuite and GetDtlsSrtpCryptoSuite are not const. Fix this. 110 // GetSslCipherSuite and GetDtlsSrtpCryptoSuite are not const. Fix this.
111 bool GetStats(const std::string& transport_name, TransportStats* stats); 111 bool GetStats(const std::string& transport_name, TransportStats* stats);
112 void SetMetricsObserver(webrtc::MetricsObserverInterface* metrics_observer); 112 void SetMetricsObserver(webrtc::MetricsObserverInterface* metrics_observer);
113 113
114 // Creates a channel if it doesn't exist. Otherwise, increments a reference 114 // Creates a channel if it doesn't exist. Otherwise, increments a reference
115 // count and returns an existing channel. 115 // count and returns an existing channel.
116 TransportChannel* CreateTransportChannel(const std::string& transport_name,
Taylor Brandstetter 2017/01/09 22:50:42 If EnableBundle were called on the networking thre
Zhi Huang 2017/01/12 03:47:46 This method could be called on other threads in We
117 int component);
116 virtual TransportChannel* CreateTransportChannel_n( 118 virtual TransportChannel* CreateTransportChannel_n(
117 const std::string& transport_name, 119 const std::string& transport_name,
118 int component); 120 int component);
119 121
120 // Decrements a channel's reference count, and destroys the channel if 122 // Decrements a channel's reference count, and destroys the channel if
121 // nothing is referencing it. 123 // nothing is referencing it.
124 void DestroyTransportChannel(const std::string& transport_name,
125 int component);
122 virtual void DestroyTransportChannel_n(const std::string& transport_name, 126 virtual void DestroyTransportChannel_n(const std::string& transport_name,
123 int component); 127 int component);
124 128
125 void use_quic() { quic_ = true; } 129 void use_quic() { quic_ = true; }
126 bool quic() const { return quic_; } 130 bool quic() const { return quic_; }
127 131
128 // TODO(deadbeef): Remove all for_testing methods! 132 // TODO(deadbeef): Remove all for_testing methods!
129 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate_for_testing() 133 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate_for_testing()
130 const { 134 const {
131 return certificate_; 135 return certificate_;
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 bool quic_ = false; 269 bool quic_ = false;
266 270
267 webrtc::MetricsObserverInterface* metrics_observer_ = nullptr; 271 webrtc::MetricsObserverInterface* metrics_observer_ = nullptr;
268 272
269 RTC_DISALLOW_COPY_AND_ASSIGN(TransportController); 273 RTC_DISALLOW_COPY_AND_ASSIGN(TransportController);
270 }; 274 };
271 275
272 } // namespace cricket 276 } // namespace cricket
273 277
274 #endif // WEBRTC_P2P_BASE_TRANSPORTCONTROLLER_H_ 278 #endif // WEBRTC_P2P_BASE_TRANSPORTCONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698