Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: webrtc/modules/video_coding/video_packet_buffer_unittest.cc

Issue 2613833003: Don't detect a new frame if a previous packet is used in a previous frame. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 EXPECT_TRUE(Insert(2, kKeyFrame, kFirst, kNotLast, 5, data2)); 453 EXPECT_TRUE(Insert(2, kKeyFrame, kFirst, kNotLast, 5, data2));
454 454
455 // Expect to free data3 upon insertion (old packet). 455 // Expect to free data3 upon insertion (old packet).
456 packet_buffer_->ClearTo(1); 456 packet_buffer_->ClearTo(1);
457 EXPECT_FALSE(Insert(1, kKeyFrame, kFirst, kNotLast, 5, data3)); 457 EXPECT_FALSE(Insert(1, kKeyFrame, kFirst, kNotLast, 5, data3));
458 458
459 // Expect to free data4 upon insertion (packet buffer is full). 459 // Expect to free data4 upon insertion (packet buffer is full).
460 EXPECT_FALSE(Insert(2 + kMaxSize, kKeyFrame, kFirst, kNotLast, 5, data4)); 460 EXPECT_FALSE(Insert(2 + kMaxSize, kKeyFrame, kFirst, kNotLast, 5, data4));
461 } 461 }
462 462
463 TEST_F(TestPacketBuffer, ContinuousSeqNumNoMarkerBit) {
464 Insert(2, kKeyFrame, kNotFirst, kNotLast);
465 Insert(1, kKeyFrame, kFirst, kLast);
466 frames_from_callback_.clear();
467 Insert(3, kKeyFrame, kNotFirst, kLast);
stefan-webrtc 2017/01/10 11:50:00 Doesn't this mean you have received the marker bit
philipel 2017/01/10 12:03:36 Renamed it to ContinuousSeqNumDoubleMarkerBit.
468
469 ASSERT_EQ(0UL, frames_from_callback_.size());
stefan-webrtc 2017/01/10 11:50:00 EXPECT_EQ
philipel 2017/01/10 12:03:36 Done.
470 }
471
463 } // namespace video_coding 472 } // namespace video_coding
464 } // namespace webrtc 473 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698