Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: webrtc/modules/audio_processing/aec3/render_delay_buffer_unittest.cc

Issue 2611223003: Adding second layer of the echo canceller 3 functionality. (Closed)
Patch Set: Changes in response to reviewer comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/modules/audio_processing/aec3/render_delay_buffer.h"
12
13 #include <memory>
14 #include <sstream>
15 #include <string>
16 #include <vector>
17
18 #include "webrtc/base/array_view.h"
19 #include "webrtc/base/random.h"
20 #include "webrtc/modules/audio_processing/aec3/aec3_constants.h"
21 #include "webrtc/modules/audio_processing/logging/apm_data_dumper.h"
22 #include "webrtc/test/gtest.h"
23
24 namespace webrtc {
25 namespace {
26
27 std::string ProduceDebugText(int sample_rate_hz) {
28 std::ostringstream ss;
29 ss << "Sample rate: " << sample_rate_hz;
30 return ss.str();
31 }
32
33 std::string ProduceDebugText(int sample_rate_hz, size_t delay) {
34 std::ostringstream ss;
35 ss << "Sample rate: " << sample_rate_hz;
36 ss << ", Delay: " << delay;
37 return ss.str();
38 }
39
40 constexpr size_t kMaxApiCallJitter = 30;
41
42 } // namespace
43
44 // Verifies that the basic swap in the insert call works.
45 TEST(RenderDelayBuffer, InsertSwap) {
46 for (auto rate : {8000, 16000, 32000, 48000}) {
47 SCOPED_TRACE(ProduceDebugText(rate));
48 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
49 250, NumBandsForRate(rate), kMaxApiCallJitter));
50 for (size_t k = 0; k < 10; ++k) {
51 std::vector<std::vector<float>> block_to_insert(
52 NumBandsForRate(rate), std::vector<float>(kBlockSize, k + 1));
53 std::vector<std::vector<float>> reference_block = block_to_insert;
54
55 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
56 EXPECT_NE(reference_block, block_to_insert);
57 }
58 }
59 }
60
61 // Verifies that the buffer passes the blocks in a bitexact manner when the
62 // delay is zero.
63 TEST(RenderDelayBuffer, BasicBitexactness) {
64 for (auto rate : {8000, 16000, 32000, 48000}) {
65 SCOPED_TRACE(ProduceDebugText(rate));
66 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
67 20, NumBandsForRate(rate), kMaxApiCallJitter));
68 for (size_t k = 0; k < 200; ++k) {
69 std::vector<std::vector<float>> block_to_insert(
70 NumBandsForRate(rate), std::vector<float>(kBlockSize, k));
71 std::vector<std::vector<float>> reference_block = block_to_insert;
72 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
73 ASSERT_TRUE(delay_buffer->IsBlockAvailable());
74 const std::vector<std::vector<float>>& output_block =
75 delay_buffer->GetNext();
76 EXPECT_EQ(reference_block, output_block);
77 }
78 }
79 }
80
81 // Verifies that the buffer passes the blocks in a bitexact manner when the
82 // delay is non-zero.
83 TEST(RenderDelayBuffer, BitexactnessWithNonZeroDelay) {
84 constexpr size_t kMaxDelay = 200;
85 for (auto rate : {8000, 16000, 32000, 48000}) {
86 for (size_t delay = 0; delay < kMaxDelay; ++delay) {
87 SCOPED_TRACE(ProduceDebugText(rate, delay));
88 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
89 20 + kMaxDelay, NumBandsForRate(rate), kMaxApiCallJitter));
90 delay_buffer->SetDelay(delay);
91 for (size_t k = 0; k < 200 + delay; ++k) {
92 std::vector<std::vector<float>> block_to_insert(
93 NumBandsForRate(rate), std::vector<float>(kBlockSize, k));
94 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
95 ASSERT_TRUE(delay_buffer->IsBlockAvailable());
96 const std::vector<std::vector<float>>& output_block =
97 delay_buffer->GetNext();
98 if (k >= delay) {
99 std::vector<std::vector<float>> reference_block(
100 NumBandsForRate(rate), std::vector<float>(kBlockSize, k - delay));
101 EXPECT_EQ(reference_block, output_block);
102 }
103 }
104 }
105 }
106 }
107
108 // Verifies that the buffer passes the blocks in a bitexact manner when the
109 // delay is zero and there is jitter in the Insert and GetNext calls.
110 TEST(RenderDelayBuffer, BasicBitexactnessWithJitter) {
111 for (auto rate : {8000, 16000, 32000, 48000}) {
112 SCOPED_TRACE(ProduceDebugText(rate));
113 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
114 20, NumBandsForRate(rate), kMaxApiCallJitter));
115 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
116 std::vector<std::vector<float>> block_to_insert(
117 NumBandsForRate(rate), std::vector<float>(kBlockSize, k));
118 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
119 }
120
121 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
122 std::vector<std::vector<float>> reference_block(
123 NumBandsForRate(rate), std::vector<float>(kBlockSize, k));
124 ASSERT_TRUE(delay_buffer->IsBlockAvailable());
125 const std::vector<std::vector<float>>& output_block =
126 delay_buffer->GetNext();
127 EXPECT_EQ(reference_block, output_block);
128 }
129 EXPECT_FALSE(delay_buffer->IsBlockAvailable());
130 }
131 }
132
133 // Verifies that the buffer passes the blocks in a bitexact manner when the
134 // delay is non-zero and there is jitter in the Insert and GetNext calls.
135 TEST(RenderDelayBuffer, BitexactnessWithNonZeroDelayAndJitter) {
136 constexpr size_t kMaxDelay = 200;
137 for (auto rate : {8000, 16000, 32000, 48000}) {
138 for (size_t delay = 0; delay < kMaxDelay; ++delay) {
139 SCOPED_TRACE(ProduceDebugText(rate, delay));
140 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
141 20 + kMaxDelay, NumBandsForRate(rate), kMaxApiCallJitter));
142 delay_buffer->SetDelay(delay);
143 for (size_t j = 0; j < 10; ++j) {
144 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
145 const size_t block_value = k + j * kMaxApiCallJitter;
146 std::vector<std::vector<float>> block_to_insert(
147 NumBandsForRate(rate),
148 std::vector<float>(kBlockSize, block_value));
149 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
150 }
151
152 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
153 ASSERT_TRUE(delay_buffer->IsBlockAvailable());
154 const std::vector<std::vector<float>>& output_block =
155 delay_buffer->GetNext();
156 const size_t block_value = k + j * kMaxApiCallJitter;
157 if (block_value >= delay) {
158 std::vector<std::vector<float>> reference_block(
159 NumBandsForRate(rate),
160 std::vector<float>(kBlockSize, block_value - delay));
161 EXPECT_EQ(reference_block, output_block);
162 }
163 }
164 }
165 }
166 }
167 }
168
169 // Verifies that no blocks present in the buffer are lost when the buffer is
170 // overflowed.
171 TEST(RenderDelayBuffer, BufferOverflowBitexactness) {
172 for (auto rate : {8000, 16000, 32000, 48000}) {
173 SCOPED_TRACE(ProduceDebugText(rate));
174 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
175 20, NumBandsForRate(rate), kMaxApiCallJitter));
176 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
177 std::vector<std::vector<float>> block_to_insert(
178 NumBandsForRate(rate), std::vector<float>(kBlockSize, k));
179 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
180 }
181
182 std::vector<std::vector<float>> block_to_insert(
183 NumBandsForRate(rate),
184 std::vector<float>(kBlockSize, kMaxApiCallJitter + 1));
185 EXPECT_FALSE(delay_buffer->Insert(&block_to_insert));
186
187 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
188 std::vector<std::vector<float>> reference_block(
189 NumBandsForRate(rate), std::vector<float>(kBlockSize, k));
190 ASSERT_TRUE(delay_buffer->IsBlockAvailable());
191 const std::vector<std::vector<float>>& output_block =
192 delay_buffer->GetNext();
193 EXPECT_EQ(reference_block, output_block);
194 }
195 EXPECT_FALSE(delay_buffer->IsBlockAvailable());
196 }
197 }
198
199 // Verifies that the buffer overflow is correctly reported.
200 TEST(RenderDelayBuffer, BufferOverflow) {
201 for (auto rate : {8000, 16000, 32000, 48000}) {
202 SCOPED_TRACE(ProduceDebugText(rate));
203 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
204 20, NumBandsForRate(rate), kMaxApiCallJitter));
205 std::vector<std::vector<float>> block_to_insert(
206 NumBandsForRate(rate), std::vector<float>(kBlockSize, 0.f));
207 for (size_t k = 0; k < kMaxApiCallJitter; ++k) {
208 EXPECT_TRUE(delay_buffer->Insert(&block_to_insert));
209 }
210 EXPECT_FALSE(delay_buffer->Insert(&block_to_insert));
211 }
212 }
213
214 // Verifies that the check for available block works.
215 TEST(RenderDelayBuffer, AvailableBlock) {
216 constexpr size_t kNumBands = 1;
217 std::unique_ptr<RenderDelayBuffer> delay_buffer(
218 RenderDelayBuffer::Create(20, kNumBands, kMaxApiCallJitter));
219 EXPECT_FALSE(delay_buffer->IsBlockAvailable());
220 std::vector<std::vector<float>> input_block(
221 kNumBands, std::vector<float>(kBlockSize, 1.f));
222 EXPECT_TRUE(delay_buffer->Insert(&input_block));
223 ASSERT_TRUE(delay_buffer->IsBlockAvailable());
224 delay_buffer->GetNext();
225 EXPECT_FALSE(delay_buffer->IsBlockAvailable());
226 }
227
228 // Verifies that the maximum delay is computed correctly.
229 TEST(RenderDelayBuffer, MaxDelay) {
230 for (size_t max_delay = 1; max_delay < 20; ++max_delay) {
231 std::unique_ptr<RenderDelayBuffer> delay_buffer(
232 RenderDelayBuffer::Create(max_delay, 1, kMaxApiCallJitter));
233 EXPECT_EQ(max_delay, delay_buffer->MaxDelay());
234 }
235 }
236
237 // Verifies the SetDelay method.
238 TEST(RenderDelayBuffer, SetDelay) {
239 std::unique_ptr<RenderDelayBuffer> delay_buffer(
240 RenderDelayBuffer::Create(20, 1, kMaxApiCallJitter));
241 EXPECT_EQ(0u, delay_buffer->Delay());
242 for (size_t delay = 0; delay < 20; ++delay) {
243 delay_buffer->SetDelay(delay);
244 EXPECT_EQ(delay, delay_buffer->Delay());
245 }
246 }
247
248 #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
249
250 // Verifies the check for null insert.
251 TEST(RenderDelayBuffer, NullPointerInInsert) {
252 std::unique_ptr<RenderDelayBuffer> delay_buffer(
253 RenderDelayBuffer::Create(20, 1, kMaxApiCallJitter));
254 EXPECT_DEATH(delay_buffer->Insert(nullptr), "");
255 }
256
257 // Verifies the check for feasible delay.
258 TEST(RenderDelayBuffer, WrongDelay) {
259 std::unique_ptr<RenderDelayBuffer> delay_buffer(
260 RenderDelayBuffer::Create(20, 1, kMaxApiCallJitter));
261 EXPECT_DEATH(delay_buffer->SetDelay(21), "");
262 }
263
264 // Verifies the check for the number of bands in the inserted blocks.
265 TEST(RenderDelayBuffer, WrongNumberOfBands) {
266 for (auto rate : {16000, 32000, 48000}) {
267 SCOPED_TRACE(ProduceDebugText(rate));
268 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
269 20, NumBandsForRate(rate), kMaxApiCallJitter));
270 std::vector<std::vector<float>> block_to_insert(
271 NumBandsForRate(rate < 48000 ? rate + 16000 : 16000),
272 std::vector<float>(kBlockSize, 0.f));
273 EXPECT_DEATH(delay_buffer->Insert(&block_to_insert), "");
274 }
275 }
276
277 // Verifies the check of the length of the inserted blocks.
278 TEST(RenderDelayBuffer, WrongBlockLength) {
279 for (auto rate : {8000, 16000, 32000, 48000}) {
280 SCOPED_TRACE(ProduceDebugText(rate));
281 std::unique_ptr<RenderDelayBuffer> delay_buffer(RenderDelayBuffer::Create(
282 20, NumBandsForRate(rate), kMaxApiCallJitter));
283 std::vector<std::vector<float>> block_to_insert(
284 NumBandsForRate(rate), std::vector<float>(kBlockSize - 1, 0.f));
285 EXPECT_DEATH(delay_buffer->Insert(&block_to_insert), "");
286 }
287 }
288
289 // Verifies the behavior when getting a block from an empty buffer.
290 TEST(RenderDelayBuffer, GetNextWithNoAvailableBlockVariant1) {
291 std::unique_ptr<RenderDelayBuffer> delay_buffer(
292 RenderDelayBuffer::Create(20, 1, kMaxApiCallJitter));
293 EXPECT_DEATH(delay_buffer->GetNext(), "");
294 }
295
296 // Verifies the behavior when getting a block from an empty buffer.
297 TEST(RenderDelayBuffer, GetNextWithNoAvailableBlockVariant2) {
298 std::unique_ptr<RenderDelayBuffer> delay_buffer(
299 RenderDelayBuffer::Create(20, 1, kMaxApiCallJitter));
300 std::vector<std::vector<float>> input_block(
301 1, std::vector<float>(kBlockSize, 1.f));
302 EXPECT_TRUE(delay_buffer->Insert(&input_block));
303 delay_buffer->GetNext();
304 EXPECT_DEATH(delay_buffer->GetNext(), "");
305 }
306
307 #endif
308
309 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698