Adding second layer of the echo canceller 3 functionality.

webrtc/modules/audio_processing/logging/apm_data_dumper.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 39 matching lines @@
   // Reinitializes the data dumping such that new versions
   // of all files being dumped to are created.
   void InitiateNewSetOfRecordings() {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     ++recording_set_index_;
 #endif
   }
 
   // Methods for performing dumping of data of various types into
   // various formats.
+  void DumpRaw(const char* name, double v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(&v, sizeof(v), 1, file);
+#endif
+  }
+
+  void DumpRaw(const char* name, int v_length, const double* v) {

[hlundin-webrtc, 2017/01/18 13:08:51]

size_t v_length

[peah-webrtc, 2017/01/19 15:33:07]

Done.

+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(v, sizeof(v[0]), v_length, file);
+#endif
+  }
+
+  void DumpRaw(const char* name, rtc::ArrayView<const double> v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    DumpRaw(name, v.size(), v.data());
+#endif
+  }
+
+  void DumpRaw(const char* name, float v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(&v, sizeof(v), 1, file);
+#endif
+  }
+
   void DumpRaw(const char* name, int v_length, const float* v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     FILE* file = GetRawFile(name);
     fwrite(v, sizeof(v[0]), v_length, file);
 #endif
   }
 
   void DumpRaw(const char* name, rtc::ArrayView<const float> v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     DumpRaw(name, v.size(), v.data());
 #endif
   }
 
+  void DumpRaw(const char* name, bool v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);

[hlundin-webrtc, 2017/01/18 13:08:51]

You could just call
DumpRaw(name, static_cast<int16_t>(v));

[peah-webrtc, 2017/01/19 15:33:07]

Good find!

Done.

+    int16_t value = static_cast<int16_t>(v);
+    fwrite(&value, sizeof(value), 1, file);
+#endif
+  }
+
   void DumpRaw(const char* name, int v_length, const bool* v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     FILE* file = GetRawFile(name);
     for (int k = 0; k < v_length; ++k) {
       int16_t value = static_cast<int16_t>(v[k]);
       fwrite(&value, sizeof(value), 1, file);
     }
 #endif
   }
 
   void DumpRaw(const char* name, rtc::ArrayView<const bool> v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     DumpRaw(name, v.size(), v.data());
 #endif
   }
 
+  void DumpRaw(const char* name, int16_t v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(&v, sizeof(v), 1, file);
+#endif
+  }
+
   void DumpRaw(const char* name, int v_length, const int16_t* v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     FILE* file = GetRawFile(name);
     fwrite(v, sizeof(v[0]), v_length, file);
 #endif
   }
 
   void DumpRaw(const char* name, rtc::ArrayView<const int16_t> v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     DumpRaw(name, v.size(), v.data());
 #endif
   }
 
+  void DumpRaw(const char* name, int32_t v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(&v, sizeof(v), 1, file);
+#endif
+  }
+
   void DumpRaw(const char* name, int v_length, const int32_t* v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     FILE* file = GetRawFile(name);
     fwrite(v, sizeof(v[0]), v_length, file);
 #endif
   }
 
+  void DumpRaw(const char* name, size_t v) {

[hlundin-webrtc, 2017/01/18 13:08:51]

Hmmm. This starts to look a bit like a candidate for templetization...

[peah-webrtc, 2017/01/19 15:33:07]

True. Let's do that. But I'd rather keep that change separate from this CL.

WDYT?

[hlundin-webrtc, 2017/01/20 09:31:44]

Good.

[peah-webrtc, 2017/01/23 14:16:39]

Acknowledged.

+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(&v, sizeof(v), 1, file);
+#endif
+  }
+
+  void DumpRaw(const char* name, int v_length, const size_t* v) {
+#if WEBRTC_APM_DEBUG_DUMP == 1
+    FILE* file = GetRawFile(name);
+    fwrite(v, sizeof(v[0]), v_length, file);
+#endif
+  }
+
   void DumpRaw(const char* name, rtc::ArrayView<const int32_t> v) {
 #if WEBRTC_APM_DEBUG_DUMP == 1
     DumpRaw(name, v.size(), v.data());
 #endif
   }
 
   void DumpWav(const char* name,
                int v_length,
                const float* v,
                int sample_rate_hz,
@@ skipping 23 matching lines @@
 
   FILE* GetRawFile(const char* name);
   WavWriter* GetWavFile(const char* name, int sample_rate_hz, int num_channels);
 #endif
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(ApmDataDumper);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_LOGGING_APM_DATA_DUMPER_H_