Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2610873002: Temporarily remove SSRC DCHECK in RTPSender::SendToNetwork. (Closed)
Patch Set: Remove DCHECK without adding clause to conditional. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index 4a285ca2198e04ec4de86e742c34fa118ededd42..99cafb6615a0ecbb11e846a2ea50504cff8c0e99 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -882,7 +882,9 @@ bool RTPSender::SendToNetwork(std::unique_ptr<RtpPacketToSend> packet,
// To support retransmissions, we store the media packet as sent in the
// packet history (even if send failed).
if (storage == kAllowRetransmission) {
- RTC_DCHECK_EQ(ssrc, SSRC());
+ // TODO(brandtr): Here we should RTC_DCHECK_EQ(ssrc, SSRC()), but that is
danilchap 2017/01/09 12:08:59 Better to phrase TODO by stating what and when sho
brandtr 2017/01/09 12:16:08 Done.
+ // currently not possible, as detailed by
+ // https://bugs.chromium.org/p/webrtc/issues/detail?id=6887.
packet_history_.PutRtpPacket(std::move(packet), storage, true);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698