Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: webrtc/modules/congestion_controller/probe_controller.cc

Issue 2609113003: BitrateProber::CreateProbeCluster now only accept one parameter (bitrate_bps). (Closed)
Patch Set: static_cast<int> + PacedSenderTest fix. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/probe_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/congestion_controller/probe_controller.cc
diff --git a/webrtc/modules/congestion_controller/probe_controller.cc b/webrtc/modules/congestion_controller/probe_controller.cc
index 6ce7d6b5df37b0a9df2cbf5e38ca710029dcf1d1..bf81517b7044d33be4ecd3fcf38896df8ff560b6 100644
--- a/webrtc/modules/congestion_controller/probe_controller.cc
+++ b/webrtc/modules/congestion_controller/probe_controller.cc
@@ -20,12 +20,6 @@
namespace webrtc {
namespace {
-
-// Number of deltas between probes per cluster. On the very first cluster,
-// we will need kProbeDeltasPerCluster + 1 probes, but on a cluster following
-// another, we need kProbeDeltasPerCluster probes.
-constexpr int kProbeDeltasPerCluster = 5;
-
// Maximum waiting time from the time of initiating probing to getting
// the measured results back.
constexpr int64_t kMaxWaitingTimeForProbingResultMs = 1000;
@@ -200,7 +194,6 @@ void ProbeController::InitiateProbing(
int64_t now_ms,
std::initializer_list<int64_t> bitrates_to_probe,
bool probe_further) {
- bool first_cluster = true;
for (int64_t bitrate : bitrates_to_probe) {
int64_t max_probe_bitrate_bps =
max_bitrate_bps_ > 0 ? max_bitrate_bps_ : kDefaultMaxProbingBitrateBps;
@@ -208,14 +201,7 @@ void ProbeController::InitiateProbing(
bitrate = max_probe_bitrate_bps;
probe_further = false;
}
- if (first_cluster) {
- pacer_->CreateProbeCluster(rtc::checked_cast<int>(bitrate),
- kProbeDeltasPerCluster + 1);
- first_cluster = false;
- } else {
- pacer_->CreateProbeCluster(rtc::checked_cast<int>(bitrate),
- kProbeDeltasPerCluster);
- }
+ pacer_->CreateProbeCluster(rtc::checked_cast<int>(bitrate));
}
time_last_probing_initiated_ms_ = now_ms;
if (probe_further) {
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/probe_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698