Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: webrtc/modules/pacing/bitrate_prober_unittest.cc

Issue 2609113003: BitrateProber::CreateProbeCluster now only accept one parameter (bitrate_bps). (Closed)
Patch Set: Comment fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <limits> 11 #include <limits>
12 12
13 #include "webrtc/modules/pacing/bitrate_prober.h" 13 #include "webrtc/modules/pacing/bitrate_prober.h"
14 #include "webrtc/test/gtest.h" 14 #include "webrtc/test/gtest.h"
15 15
16 namespace webrtc { 16 namespace webrtc {
17 17
18 TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) { 18 TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) {
19 BitrateProber prober; 19 BitrateProber prober;
20 EXPECT_FALSE(prober.IsProbing()); 20 EXPECT_FALSE(prober.IsProbing());
21 int64_t now_ms = 0; 21 int64_t now_ms = 0;
22 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 22 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
23 23
24 prober.CreateProbeCluster(900000, 6); 24 prober.CreateProbeCluster(900000);
25 prober.CreateProbeCluster(1800000, 5); 25 prober.CreateProbeCluster(1800000);
26 EXPECT_FALSE(prober.IsProbing()); 26 EXPECT_FALSE(prober.IsProbing());
27 27
28 prober.OnIncomingPacket(1000); 28 prober.OnIncomingPacket(1000);
29 EXPECT_TRUE(prober.IsProbing()); 29 EXPECT_TRUE(prober.IsProbing());
30 EXPECT_EQ(0, prober.CurrentClusterId()); 30 EXPECT_EQ(0, prober.CurrentClusterId());
31 31
32 // First packet should probe as soon as possible. 32 // First packet should probe as soon as possible.
33 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms)); 33 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
34 prober.ProbeSent(now_ms, 1000); 34 prober.ProbeSent(now_ms, 1000);
35 35
(...skipping 17 matching lines...) Expand all
53 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 53 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
54 EXPECT_FALSE(prober.IsProbing()); 54 EXPECT_FALSE(prober.IsProbing());
55 } 55 }
56 56
57 TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) { 57 TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) {
58 BitrateProber prober; 58 BitrateProber prober;
59 EXPECT_FALSE(prober.IsProbing()); 59 EXPECT_FALSE(prober.IsProbing());
60 int64_t now_ms = 0; 60 int64_t now_ms = 0;
61 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 61 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
62 62
63 prober.CreateProbeCluster(900000, 6); 63 prober.CreateProbeCluster(900000);
64 EXPECT_FALSE(prober.IsProbing()); 64 EXPECT_FALSE(prober.IsProbing());
65 65
66 prober.OnIncomingPacket(1000); 66 prober.OnIncomingPacket(1000);
67 EXPECT_TRUE(prober.IsProbing()); 67 EXPECT_TRUE(prober.IsProbing());
68 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms)); 68 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
69 prober.ProbeSent(now_ms, 1000); 69 prober.ProbeSent(now_ms, 1000);
70 // Let time pass, no large enough packets put into prober. 70 // Let time pass, no large enough packets put into prober.
71 now_ms += 6000; 71 now_ms += 6000;
72 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 72 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
73 // Insert a small packet, not a candidate for probing. 73 // Insert a small packet, not a candidate for probing.
(...skipping 16 matching lines...) Expand all
90 EXPECT_FALSE(prober.IsProbing()); 90 EXPECT_FALSE(prober.IsProbing());
91 91
92 prober.OnIncomingPacket(100); 92 prober.OnIncomingPacket(100);
93 EXPECT_FALSE(prober.IsProbing()); 93 EXPECT_FALSE(prober.IsProbing());
94 } 94 }
95 95
96 TEST(BitrateProberTest, VerifyProbeSizeOnHighBitrate) { 96 TEST(BitrateProberTest, VerifyProbeSizeOnHighBitrate) {
97 BitrateProber prober; 97 BitrateProber prober;
98 constexpr unsigned kHighBitrateBps = 10000000; // 10 Mbps 98 constexpr unsigned kHighBitrateBps = 10000000; // 10 Mbps
99 99
100 prober.CreateProbeCluster(kHighBitrateBps, 6); 100 prober.CreateProbeCluster(kHighBitrateBps);
101 // Probe size should ensure a minimum of 1 ms interval. 101 // Probe size should ensure a minimum of 1 ms interval.
102 EXPECT_GT(prober.RecommendedMinProbeSize(), kHighBitrateBps / 8000); 102 EXPECT_GT(prober.RecommendedMinProbeSize(), kHighBitrateBps / 8000);
103 } 103 }
104 104
105 } // namespace webrtc 105 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698