Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: webrtc/p2p/base/transportcontroller.h

Issue 2606123002: Remove the dependency of TransportChannel and TransportChannelImpl. (Closed)
Patch Set: Fix the memory leak. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/transportchannel.cc ('k') | webrtc/p2p/base/transportcontroller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/transportcontroller.h
diff --git a/webrtc/p2p/base/transportcontroller.h b/webrtc/p2p/base/transportcontroller.h
index 6929a6e7f16a1a2094b920957ce6f10b97c4ffb9..33306c714fc378ffa5f5e26bd3e4eaea6176f274 100644
--- a/webrtc/p2p/base/transportcontroller.h
+++ b/webrtc/p2p/base/transportcontroller.h
@@ -113,18 +113,18 @@ class TransportController : public sigslot::has_slots<>,
// Creates a channel if it doesn't exist. Otherwise, increments a reference
// count and returns an existing channel.
- TransportChannel* CreateTransportChannel(const std::string& transport_name,
- int component);
- virtual TransportChannel* CreateTransportChannel_n(
+ DtlsTransportInternal* CreateDtlsTransport(const std::string& transport_name,
+ int component);
+ virtual DtlsTransportInternal* CreateDtlsTransport_n(
const std::string& transport_name,
int component);
// Decrements a channel's reference count, and destroys the channel if
// nothing is referencing it.
- virtual void DestroyTransportChannel(const std::string& transport_name,
- int component);
- virtual void DestroyTransportChannel_n(const std::string& transport_name,
- int component);
+ virtual void DestroyDtlsTransport(const std::string& transport_name,
+ int component);
+ virtual void DestroyDtlsTransport_n(const std::string& transport_name,
+ int component);
void use_quic() { quic_ = true; }
bool quic() const { return quic_; }
@@ -135,8 +135,8 @@ class TransportController : public sigslot::has_slots<>,
return certificate_;
}
std::vector<std::string> transport_names_for_testing();
- std::vector<TransportChannelImpl*> channels_for_testing();
- TransportChannelImpl* get_channel_for_testing(
+ std::vector<DtlsTransportInternal*> channels_for_testing();
+ DtlsTransportInternal* get_channel_for_testing(
const std::string& transport_name,
int component);
@@ -171,7 +171,7 @@ class TransportController : public sigslot::has_slots<>,
virtual IceTransportInternal* CreateIceTransportChannel_n(
const std::string& transport_name,
int component);
- virtual TransportChannelImpl* CreateDtlsTransportChannel_n(
+ virtual DtlsTransportInternal* CreateDtlsTransportChannel_n(
const std::string& transport_name,
int component,
IceTransportInternal* ice);
@@ -233,14 +233,14 @@ class TransportController : public sigslot::has_slots<>,
// Handlers for signals from Transport.
void OnChannelWritableState_n(rtc::PacketTransportInterface* transport);
void OnChannelReceivingState_n(rtc::PacketTransportInterface* transport);
- void OnChannelGatheringState_n(TransportChannelImpl* channel);
- void OnChannelCandidateGathered_n(TransportChannelImpl* channel,
+ void OnChannelGatheringState_n(IceTransportInternal* channel);
+ void OnChannelCandidateGathered_n(IceTransportInternal* channel,
const Candidate& candidate);
void OnChannelCandidatesRemoved(const Candidates& candidates);
- void OnChannelCandidatesRemoved_n(TransportChannelImpl* channel,
+ void OnChannelCandidatesRemoved_n(IceTransportInternal* channel,
const Candidates& candidates);
- void OnChannelRoleConflict_n(TransportChannelImpl* channel);
- void OnChannelStateChanged_n(TransportChannelImpl* channel);
+ void OnChannelRoleConflict_n(IceTransportInternal* channel);
+ void OnChannelStateChanged_n(IceTransportInternal* channel);
void UpdateAggregateStates_n();
« no previous file with comments | « webrtc/p2p/base/transportchannel.cc ('k') | webrtc/p2p/base/transportcontroller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698