webrtc/api/peerconnection.h - Issue 2605033002: RTCMediaStreamTrackStats.ssrcIds collected by RTCStatsCollector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnection.h

Issue 2605033002: RTCMediaStreamTrackStats.ssrcIds collected by RTCStatsCollector. (Closed)

Patch Set: Rebase with master (reupload from other machine to create dependent patchset) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnection.h

diff --git a/webrtc/api/peerconnection.h b/webrtc/api/peerconnection.h

index 5269e3ae498ed3dfa2210da13ba40139ec8170af..a138171eabece7d05e8853729750f70a306a821a 100644

--- a/webrtc/api/peerconnection.h

+++ b/webrtc/api/peerconnection.h

@@ -93,9 +93,10 @@ class PeerConnection : public PeerConnectionInterface,

const std::string& kind,

const std::string& stream_id) override;

- std::vector<rtc::scoped_refptr<RtpSenderInterface>> GetSenders()

+ // Virtual for unit tests.

+ virtual std::vector<rtc::scoped_refptr<RtpSenderInterface>> GetSenders()

Taylor Brandstetter 2017/01/04 00:36:55 These are already virtual (hence "override" at the

const override;

- std::vector<rtc::scoped_refptr<RtpReceiverInterface>> GetReceivers()

+ virtual std::vector<rtc::scoped_refptr<RtpReceiverInterface>> GetReceivers()

const override;

rtc::scoped_refptr<DataChannelInterface> CreateDataChannel(