Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: webrtc/api/rtcstats_integrationtest.cc

Issue 2597963002: RTCIceCandidateStats.transportId added and collected. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector.cc » ('j') | webrtc/api/rtcstatscollector.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 verifier.TestMemberIsUndefined(candidate_pair.consent_requests_received); 347 verifier.TestMemberIsUndefined(candidate_pair.consent_requests_received);
348 verifier.TestMemberIsDefined(candidate_pair.consent_requests_sent); 348 verifier.TestMemberIsDefined(candidate_pair.consent_requests_sent);
349 verifier.TestMemberIsUndefined(candidate_pair.consent_responses_received); 349 verifier.TestMemberIsUndefined(candidate_pair.consent_responses_received);
350 verifier.TestMemberIsUndefined(candidate_pair.consent_responses_sent); 350 verifier.TestMemberIsUndefined(candidate_pair.consent_responses_sent);
351 return verifier.ExpectAllMembersSuccessfullyTested(); 351 return verifier.ExpectAllMembersSuccessfullyTested();
352 } 352 }
353 353
354 bool VerifyRTCIceCandidateStats( 354 bool VerifyRTCIceCandidateStats(
355 const RTCIceCandidateStats& candidate) { 355 const RTCIceCandidateStats& candidate) {
356 RTCStatsVerifier verifier(report_, &candidate); 356 RTCStatsVerifier verifier(report_, &candidate);
357 // TODO(hbos): Why is this not present, meaning
358 // |cricket::Candidate::transport_name| is an empty string? crbug.com/632723
359 verifier.TestMemberIsOptionalIDReference(
Taylor Brandstetter 2016/12/22 19:28:31 Should get rid of "Optional"
hbos 2016/12/23 14:25:17 Done.
360 candidate.transport_id, RTCTransportStats::kType);
357 verifier.TestMemberIsDefined(candidate.ip); 361 verifier.TestMemberIsDefined(candidate.ip);
358 verifier.TestMemberIsDefined(candidate.port); 362 verifier.TestMemberIsDefined(candidate.port);
359 verifier.TestMemberIsDefined(candidate.protocol); 363 verifier.TestMemberIsDefined(candidate.protocol);
360 verifier.TestMemberIsDefined(candidate.candidate_type); 364 verifier.TestMemberIsDefined(candidate.candidate_type);
361 verifier.TestMemberIsDefined(candidate.priority); 365 verifier.TestMemberIsDefined(candidate.priority);
362 verifier.TestMemberIsUndefined(candidate.url); 366 verifier.TestMemberIsUndefined(candidate.url);
363 return verifier.ExpectAllMembersSuccessfullyTested(); 367 return verifier.ExpectAllMembersSuccessfullyTested();
364 } 368 }
365 369
366 bool VerifyRTCLocalIceCandidateStats( 370 bool VerifyRTCLocalIceCandidateStats(
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 // This will destroy the peer connection. 550 // This will destroy the peer connection.
547 caller_ = nullptr; 551 caller_ = nullptr;
548 // Any pending stats requests should have completed in the act of destroying 552 // Any pending stats requests should have completed in the act of destroying
549 // the peer connection. 553 // the peer connection.
550 EXPECT_TRUE(stats_obtainer->report()); 554 EXPECT_TRUE(stats_obtainer->report());
551 } 555 }
552 556
553 } // namespace 557 } // namespace
554 558
555 } // namespace webrtc 559 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector.cc » ('j') | webrtc/api/rtcstatscollector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698