Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2597423003: RTCIceCandidatePairStats.[state/priority] added, ConnectionInfo updated. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/rtcstatscollector_unittest.cc ('K') | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/p2p/base/jseptransport.h » ('j') | webrtc/p2p/base/jseptransport.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 429f93b755989a68793dcb46145ee586ebce422c..d1484b578441c98281a603456e0a7027f3f2599a 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -32,7 +32,6 @@ struct RTCStatsIceCandidatePairState {
static const char* kInProgress;
static const char* kFailed;
static const char* kSucceeded;
- static const char* kCancelled;
hbos 2016/12/23 13:45:34 Our implementation does not support this value and
};
// https://w3c.github.io/webrtc-pc/#rtcicecandidatetype-enum
@@ -120,9 +119,7 @@ class RTCIceCandidatePairStats final : public RTCStats {
RTCStatsMember<std::string> remote_candidate_id;
// TODO(hbos): Support enum types?
// "RTCStatsMember<RTCStatsIceCandidatePairState>"?
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/633550
RTCStatsMember<std::string> state;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/633550
RTCStatsMember<uint64_t> priority;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/633550
RTCStatsMember<bool> nominated;
« webrtc/api/rtcstatscollector_unittest.cc ('K') | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/p2p/base/jseptransport.h » ('j') | webrtc/p2p/base/jseptransport.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698