Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2593503003: RTCStatsReport::AddStats DCHECKs that the ID is unique. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstatsreport.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 a_transport_channel_stats.connection_infos[0].local_candidate = 962 a_transport_channel_stats.connection_infos[0].local_candidate =
963 *a_local_host.get(); 963 *a_local_host.get();
964 a_transport_channel_stats.connection_infos[0].remote_candidate = 964 a_transport_channel_stats.connection_infos[0].remote_candidate =
965 *a_remote_srflx.get(); 965 *a_remote_srflx.get();
966 a_transport_channel_stats.connection_infos.push_back( 966 a_transport_channel_stats.connection_infos.push_back(
967 cricket::ConnectionInfo()); 967 cricket::ConnectionInfo());
968 a_transport_channel_stats.connection_infos[1].local_candidate = 968 a_transport_channel_stats.connection_infos[1].local_candidate =
969 *a_local_prflx.get(); 969 *a_local_prflx.get();
970 a_transport_channel_stats.connection_infos[1].remote_candidate = 970 a_transport_channel_stats.connection_infos[1].remote_candidate =
971 *a_remote_relay.get(); 971 *a_remote_relay.get();
972 session_stats.transport_stats["a"].transport_name = "a";
972 session_stats.transport_stats["a"].channel_stats.push_back( 973 session_stats.transport_stats["a"].channel_stats.push_back(
973 a_transport_channel_stats); 974 a_transport_channel_stats);
974 975
975 cricket::TransportChannelStats b_transport_channel_stats; 976 cricket::TransportChannelStats b_transport_channel_stats;
976 b_transport_channel_stats.connection_infos.push_back( 977 b_transport_channel_stats.connection_infos.push_back(
977 cricket::ConnectionInfo()); 978 cricket::ConnectionInfo());
978 b_transport_channel_stats.connection_infos[0].local_candidate = 979 b_transport_channel_stats.connection_infos[0].local_candidate =
979 *b_local.get(); 980 *b_local.get();
980 b_transport_channel_stats.connection_infos[0].remote_candidate = 981 b_transport_channel_stats.connection_infos[0].remote_candidate =
981 *b_remote.get(); 982 *b_remote.get();
983 session_stats.transport_stats["b"].transport_name = "b";
982 session_stats.transport_stats["b"].channel_stats.push_back( 984 session_stats.transport_stats["b"].channel_stats.push_back(
983 b_transport_channel_stats); 985 b_transport_channel_stats);
984 986
985 // Mock the session to return the desired candidates. 987 // Mock the session to return the desired candidates.
986 EXPECT_CALL(test_->session(), GetStats(_)).WillRepeatedly(Invoke( 988 EXPECT_CALL(test_->session(), GetStats(_)).WillRepeatedly(Invoke(
987 [&session_stats](const ChannelNamePairs&) { 989 [&session_stats](const ChannelNamePairs&) {
988 return std::unique_ptr<SessionStats>(new SessionStats(session_stats)); 990 return std::unique_ptr<SessionStats>(new SessionStats(session_stats));
989 })); 991 }));
990 992
991 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport(); 993 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport();
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
1157 FakeAudioTrackForStats::Create( 1159 FakeAudioTrackForStats::Create(
1158 "RemoteAudioTrackID", 1160 "RemoteAudioTrackID",
1159 MediaStreamTrackInterface::TrackState::kLive, 1161 MediaStreamTrackInterface::TrackState::kLive,
1160 0, 1162 0,
1161 new FakeAudioProcessorForStats(remote_audio_processor_stats)); 1163 new FakeAudioProcessorForStats(remote_audio_processor_stats));
1162 remote_stream->AddTrack(remote_audio_track); 1164 remote_stream->AddTrack(remote_audio_track);
1163 1165
1164 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport(); 1166 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport();
1165 1167
1166 RTCMediaStreamStats expected_local_stream( 1168 RTCMediaStreamStats expected_local_stream(
1167 "RTCMediaStream_LocalStreamLabel", report->timestamp_us()); 1169 "RTCMediaStream_local_LocalStreamLabel", report->timestamp_us());
1168 expected_local_stream.stream_identifier = local_stream->label(); 1170 expected_local_stream.stream_identifier = local_stream->label();
1169 expected_local_stream.track_ids = std::vector<std::string>(); 1171 expected_local_stream.track_ids = std::vector<std::string>();
1170 expected_local_stream.track_ids->push_back( 1172 expected_local_stream.track_ids->push_back(
1171 "RTCMediaStreamTrack_LocalAudioTrackID"); 1173 "RTCMediaStreamTrack_LocalAudioTrackID");
1172 EXPECT_TRUE(report->Get(expected_local_stream.id())); 1174 EXPECT_TRUE(report->Get(expected_local_stream.id()));
1173 EXPECT_EQ(expected_local_stream, 1175 EXPECT_EQ(expected_local_stream,
1174 report->Get(expected_local_stream.id())->cast_to< 1176 report->Get(expected_local_stream.id())->cast_to<
1175 RTCMediaStreamStats>()); 1177 RTCMediaStreamStats>());
1176 1178
1177 RTCMediaStreamStats expected_remote_stream( 1179 RTCMediaStreamStats expected_remote_stream(
1178 "RTCMediaStream_RemoteStreamLabel", report->timestamp_us()); 1180 "RTCMediaStream_remote_RemoteStreamLabel", report->timestamp_us());
1179 expected_remote_stream.stream_identifier = remote_stream->label(); 1181 expected_remote_stream.stream_identifier = remote_stream->label();
1180 expected_remote_stream.track_ids = std::vector<std::string>(); 1182 expected_remote_stream.track_ids = std::vector<std::string>();
1181 expected_remote_stream.track_ids->push_back( 1183 expected_remote_stream.track_ids->push_back(
1182 "RTCMediaStreamTrack_RemoteAudioTrackID"); 1184 "RTCMediaStreamTrack_RemoteAudioTrackID");
1183 EXPECT_TRUE(report->Get(expected_remote_stream.id())); 1185 EXPECT_TRUE(report->Get(expected_remote_stream.id()));
1184 EXPECT_EQ(expected_remote_stream, 1186 EXPECT_EQ(expected_remote_stream,
1185 report->Get(expected_remote_stream.id())->cast_to< 1187 report->Get(expected_remote_stream.id())->cast_to<
1186 RTCMediaStreamStats>()); 1188 RTCMediaStreamStats>());
1187 1189
1188 RTCMediaStreamTrackStats expected_local_audio_track( 1190 RTCMediaStreamTrackStats expected_local_audio_track(
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
1294 rtc::scoped_refptr<FakeVideoTrackForStats> remote_video_track = 1296 rtc::scoped_refptr<FakeVideoTrackForStats> remote_video_track =
1295 FakeVideoTrackForStats::Create( 1297 FakeVideoTrackForStats::Create(
1296 "RemoteVideoTrackID", 1298 "RemoteVideoTrackID",
1297 MediaStreamTrackInterface::TrackState::kEnded, 1299 MediaStreamTrackInterface::TrackState::kEnded,
1298 remote_video_track_source); 1300 remote_video_track_source);
1299 remote_stream->AddTrack(remote_video_track); 1301 remote_stream->AddTrack(remote_video_track);
1300 1302
1301 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport(); 1303 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport();
1302 1304
1303 RTCMediaStreamStats expected_local_stream( 1305 RTCMediaStreamStats expected_local_stream(
1304 "RTCMediaStream_LocalStreamLabel", report->timestamp_us()); 1306 "RTCMediaStream_local_LocalStreamLabel", report->timestamp_us());
1305 expected_local_stream.stream_identifier = local_stream->label(); 1307 expected_local_stream.stream_identifier = local_stream->label();
1306 expected_local_stream.track_ids = std::vector<std::string>(); 1308 expected_local_stream.track_ids = std::vector<std::string>();
1307 expected_local_stream.track_ids->push_back( 1309 expected_local_stream.track_ids->push_back(
1308 "RTCMediaStreamTrack_LocalVideoTrackID"); 1310 "RTCMediaStreamTrack_LocalVideoTrackID");
1309 EXPECT_TRUE(report->Get(expected_local_stream.id())); 1311 EXPECT_TRUE(report->Get(expected_local_stream.id()));
1310 EXPECT_EQ(expected_local_stream, 1312 EXPECT_EQ(expected_local_stream,
1311 report->Get(expected_local_stream.id())->cast_to< 1313 report->Get(expected_local_stream.id())->cast_to<
1312 RTCMediaStreamStats>()); 1314 RTCMediaStreamStats>());
1313 1315
1314 RTCMediaStreamStats expected_remote_stream( 1316 RTCMediaStreamStats expected_remote_stream(
1315 "RTCMediaStream_RemoteStreamLabel", report->timestamp_us()); 1317 "RTCMediaStream_remote_RemoteStreamLabel", report->timestamp_us());
1316 expected_remote_stream.stream_identifier = remote_stream->label(); 1318 expected_remote_stream.stream_identifier = remote_stream->label();
1317 expected_remote_stream.track_ids = std::vector<std::string>(); 1319 expected_remote_stream.track_ids = std::vector<std::string>();
1318 expected_remote_stream.track_ids->push_back( 1320 expected_remote_stream.track_ids->push_back(
1319 "RTCMediaStreamTrack_RemoteVideoTrackID"); 1321 "RTCMediaStreamTrack_RemoteVideoTrackID");
1320 EXPECT_TRUE(report->Get(expected_remote_stream.id())); 1322 EXPECT_TRUE(report->Get(expected_remote_stream.id()));
1321 EXPECT_EQ(expected_remote_stream, 1323 EXPECT_EQ(expected_remote_stream,
1322 report->Get(expected_remote_stream.id())->cast_to< 1324 report->Get(expected_remote_stream.id())->cast_to<
1323 RTCMediaStreamStats>()); 1325 RTCMediaStreamStats>());
1324 1326
1325 RTCMediaStreamTrackStats expected_local_video_track( 1327 RTCMediaStreamTrackStats expected_local_video_track(
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
1907 rtc::scoped_refptr<FakeRTCStatsCollector> collector_; 1909 rtc::scoped_refptr<FakeRTCStatsCollector> collector_;
1908 }; 1910 };
1909 1911
1910 TEST_F(RTCStatsCollectorTestWithFakeCollector, ThreadUsageAndResultsMerging) { 1912 TEST_F(RTCStatsCollectorTestWithFakeCollector, ThreadUsageAndResultsMerging) {
1911 collector_->VerifyThreadUsageAndResultsMerging(); 1913 collector_->VerifyThreadUsageAndResultsMerging();
1912 } 1914 }
1913 1915
1914 } // namespace 1916 } // namespace
1915 1917
1916 } // namespace webrtc 1918 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstatsreport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698