Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

Issue 2589743002: Make OverheadObserver::OnOverheadChanged count RTP headers only (Closed)
Patch Set: Add explicit cast. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | webrtc/video/video_send_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
index 2a30043b9f5d335553c94e73cffc951b01e4ba40..7c7db4dabc7e936a8ad7ee4b6fad16ecba031dbe 100644
--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
@@ -130,20 +130,10 @@ TEST_F(RtpRtcpAPITest, Basic) {
EXPECT_TRUE(module_->Sending());
}
-TEST_F(RtpRtcpAPITest, MTU) {
- EXPECT_EQ(0, module_->SetMaxTransferUnit(1234));
- EXPECT_EQ(1234 - 20 - 8, module_->MaxPayloadLength());
-
- EXPECT_EQ(0, module_->SetTransportOverhead(true, true, 12));
- EXPECT_EQ(1234 - 20 - 20 - 20 - 12, module_->MaxPayloadLength());
-
- EXPECT_EQ(0, module_->SetTransportOverhead(false, false, 0));
- EXPECT_EQ(1234 - 20 - 8, module_->MaxPayloadLength());
-
- module_->SetTransportOverhead(28);
- EXPECT_EQ(1234 - 28, module_->MaxPayloadLength());
- module_->SetTransportOverhead(44);
- EXPECT_EQ(1234 - 44, module_->MaxPayloadLength());
+TEST_F(RtpRtcpAPITest, PacketSize) {
+ module_->SetMaxRtpPacketSize(1234);
+ EXPECT_EQ(1234u, module_->MaxRtpPacketSize());
+ EXPECT_EQ(1234u - 12u /* Minimum RTP header */, module_->MaxPayloadSize());
}
TEST_F(RtpRtcpAPITest, SSRC) {
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | webrtc/video/video_send_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698