Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: webrtc/video/video_quality_test.cc

Issue 2589713003: Make |rtcp_send_transport| mandatory in FlexfecReceiveStream::Config. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/end_to_end_tests.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_quality_test.cc
diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
index 7173e01845f00738e408dfb63a11de7d12ab6210..e37b555f7e35bc1eb717f90dea3ce4b658ab8d18 100644
--- a/webrtc/video/video_quality_test.cc
+++ b/webrtc/video/video_quality_test.cc
@@ -1044,8 +1044,9 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
if (params_.logs)
trace_to_stderr_.reset(new test::TraceToStderr);
- size_t num_streams = params_.ss.streams.size();
- CreateSendConfig(num_streams, 0, 0, send_transport);
+ size_t num_video_streams = params_.ss.streams.size();
+ size_t num_flexfec_streams = params_.video.flexfec ? 1 : 0;
+ CreateSendConfig(num_video_streams, 0, num_flexfec_streams, send_transport);
int payload_type;
if (params_.video.codec == "H264") {
@@ -1066,7 +1067,7 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
video_send_config_.encoder_settings.payload_type = payload_type;
video_send_config_.rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
video_send_config_.rtp.rtx.payload_type = kSendRtxPayloadType;
- for (size_t i = 0; i < num_streams; ++i)
+ for (size_t i = 0; i < num_video_streams; ++i)
video_send_config_.rtp.rtx.ssrcs.push_back(kSendRtxSsrcs[i]);
video_send_config_.rtp.extensions.clear();
@@ -1098,7 +1099,7 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
CreateMatchingReceiveConfigs(recv_transport);
- for (size_t i = 0; i < num_streams; ++i) {
+ for (size_t i = 0; i < num_video_streams; ++i) {
video_receive_configs_[i].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
video_receive_configs_[i].rtp.rtx[payload_type].ssrc = kSendRtxSsrcs[i];
video_receive_configs_[i].rtp.rtx[payload_type].payload_type =
@@ -1107,12 +1108,14 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
}
if (params_.video.flexfec) {
- video_send_config_.rtp.flexfec.flexfec_payload_type = kFlexfecPayloadType;
- video_send_config_.rtp.flexfec.flexfec_ssrc = kFlexfecSendSsrc;
+ // Override send config constructed by CreateSendConfig.
video_send_config_.rtp.flexfec.protected_media_ssrcs = {
kVideoSendSsrcs[params_.ss.selected_stream]};
- FlexfecReceiveStream::Config flexfec_receive_config;
+ // The matching receive config is _not_ created by
+ // CreateMatchingReceiveConfigs, since VideoQualityTest is not a BaseTest.
+ // Set up the receive config manually instead.
+ FlexfecReceiveStream::Config flexfec_receive_config(recv_transport);
flexfec_receive_config.payload_type =
video_send_config_.rtp.flexfec.flexfec_payload_type;
flexfec_receive_config.remote_ssrc =
« no previous file with comments | « webrtc/video/end_to_end_tests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698