Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: webrtc/video/video_quality_test.cc

Issue 2589713003: Make |rtcp_send_transport| mandatory in FlexfecReceiveStream::Config. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_quality_test.cc
diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
index 74bf5562fb24d3ef2dcdff86986ee238816fa6b8..135cab617bb7f70460e917e1c18dd374fc2c8746 100644
--- a/webrtc/video/video_quality_test.cc
+++ b/webrtc/video/video_quality_test.cc
@@ -1018,8 +1018,9 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
if (params_.logs)
trace_to_stderr_.reset(new test::TraceToStderr);
- size_t num_streams = params_.ss.streams.size();
- CreateSendConfig(num_streams, 0, 0, send_transport);
+ size_t num_video_streams = params_.ss.streams.size();
+ size_t num_flexfec_streams = params_.video.flexfec ? 1 : 0;
+ CreateSendConfig(num_video_streams, 0, num_flexfec_streams, send_transport);
int payload_type;
if (params_.video.codec == "H264") {
@@ -1040,7 +1041,7 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
video_send_config_.encoder_settings.payload_type = payload_type;
video_send_config_.rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
video_send_config_.rtp.rtx.payload_type = kSendRtxPayloadType;
- for (size_t i = 0; i < num_streams; ++i)
+ for (size_t i = 0; i < num_video_streams; ++i)
video_send_config_.rtp.rtx.ssrcs.push_back(kSendRtxSsrcs[i]);
video_send_config_.rtp.extensions.clear();
@@ -1072,7 +1073,7 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
CreateMatchingReceiveConfigs(recv_transport);
- for (size_t i = 0; i < num_streams; ++i) {
+ for (size_t i = 0; i < num_video_streams; ++i) {
video_receive_configs_[i].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
video_receive_configs_[i].rtp.rtx[payload_type].ssrc = kSendRtxSsrcs[i];
video_receive_configs_[i].rtp.rtx[payload_type].payload_type =
@@ -1081,19 +1082,12 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
}
if (params_.video.flexfec) {
- video_send_config_.rtp.flexfec.flexfec_payload_type = kFlexfecPayloadType;
- video_send_config_.rtp.flexfec.flexfec_ssrc = kFlexfecSendSsrc;
video_send_config_.rtp.flexfec.protected_media_ssrcs = {
kVideoSendSsrcs[params_.ss.selected_stream]};
- FlexfecReceiveStream::Config flexfec_receive_config;
- flexfec_receive_config.payload_type =
- video_send_config_.rtp.flexfec.flexfec_payload_type;
- flexfec_receive_config.remote_ssrc =
- video_send_config_.rtp.flexfec.flexfec_ssrc;
- flexfec_receive_config.protected_media_ssrcs =
+ RTC_DCHECK(!flexfec_receive_configs_.empty());
+ flexfec_receive_configs_[0].protected_media_ssrcs =
video_send_config_.rtp.flexfec.protected_media_ssrcs;
- flexfec_receive_configs_.push_back(flexfec_receive_config);
}
if (params_.video.ulpfec) {
« webrtc/media/engine/webrtcvideoengine2.h ('K') | « webrtc/video/end_to_end_tests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698