Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: webrtc/call/flexfec_receive_stream.h

Issue 2589713003: Make |rtcp_send_transport| mandatory in FlexfecReceiveStream::Config. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/call/call_unittest.cc ('k') | webrtc/call/flexfec_receive_stream_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 13 matching lines...) Expand all
24 class FlexfecReceiveStream { 24 class FlexfecReceiveStream {
25 public: 25 public:
26 struct Stats { 26 struct Stats {
27 std::string ToString(int64_t time_ms) const; 27 std::string ToString(int64_t time_ms) const;
28 28
29 // TODO(brandtr): Add appropriate stats here. 29 // TODO(brandtr): Add appropriate stats here.
30 int flexfec_bitrate_bps; 30 int flexfec_bitrate_bps;
31 }; 31 };
32 32
33 struct Config { 33 struct Config {
34 explicit Config(Transport* rtcp_send_transport)
35 : rtcp_send_transport(rtcp_send_transport) {
36 RTC_DCHECK(rtcp_send_transport);
37 }
38
34 std::string ToString() const; 39 std::string ToString() const;
35 40
41 // Returns true if all RTP information is available in order to
42 // enable receiving FlexFEC.
43 bool IsCompleteAndEnabled() const;
44
36 // Payload type for FlexFEC. 45 // Payload type for FlexFEC.
37 int payload_type = -1; 46 int payload_type = -1;
38 47
39 // SSRC for FlexFEC stream to be received. 48 // SSRC for FlexFEC stream to be received.
40 uint32_t remote_ssrc = 0; 49 uint32_t remote_ssrc = 0;
41 50
42 // Vector containing a single element, corresponding to the SSRC of the 51 // Vector containing a single element, corresponding to the SSRC of the
43 // media stream being protected by this FlexFEC stream. The vector MUST have 52 // media stream being protected by this FlexFEC stream. The vector MUST have
44 // size 1. 53 // size 1.
45 // 54 //
(...skipping 27 matching lines...) Expand all
73 82
74 virtual Stats GetStats() const = 0; 83 virtual Stats GetStats() const = 0;
75 84
76 protected: 85 protected:
77 virtual ~FlexfecReceiveStream() = default; 86 virtual ~FlexfecReceiveStream() = default;
78 }; 87 };
79 88
80 } // namespace webrtc 89 } // namespace webrtc
81 90
82 #endif // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_H_ 91 #endif // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/call/call_unittest.cc ('k') | webrtc/call/flexfec_receive_stream_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698