Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: webrtc/call/flexfec_receive_stream.h

Issue 2589713003: Make |rtcp_send_transport| mandatory in FlexfecReceiveStream::Config. (Closed)
Patch Set: Clarify config setup in VideoQualityTest a bit. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 class FlexfecReceiveStream { 22 class FlexfecReceiveStream {
23 public: 23 public:
24 struct Stats { 24 struct Stats {
25 std::string ToString(int64_t time_ms) const; 25 std::string ToString(int64_t time_ms) const;
26 26
27 // TODO(brandtr): Add appropriate stats here. 27 // TODO(brandtr): Add appropriate stats here.
28 int flexfec_bitrate_bps; 28 int flexfec_bitrate_bps;
29 }; 29 };
30 30
31 struct Config { 31 struct Config {
32 explicit Config(Transport* rtcp_send_transport)
33 : rtcp_send_transport(rtcp_send_transport) {}
34
32 std::string ToString() const; 35 std::string ToString() const;
33 36
37 // Returns true if all RTP information is available in order to
38 // enable receiving FlexFEC.
39 bool IsCompleteAndEnabled() const;
stefan-webrtc 2016/12/22 09:14:54 Is this used for anything but tests? If not, I'd p
brandtr 2017/01/03 10:01:05 Yes, it's used here: https://codereview.webrtc.org
40
34 // Payload type for FlexFEC. 41 // Payload type for FlexFEC.
35 int payload_type = -1; 42 int payload_type = -1;
36 43
37 // SSRC for FlexFEC stream to be received. 44 // SSRC for FlexFEC stream to be received.
38 uint32_t remote_ssrc = 0; 45 uint32_t remote_ssrc = 0;
39 46
40 // Vector containing a single element, corresponding to the SSRC of the 47 // Vector containing a single element, corresponding to the SSRC of the
41 // media stream being protected by this FlexFEC stream. The vector MUST have 48 // media stream being protected by this FlexFEC stream. The vector MUST have
42 // size 1. 49 // size 1.
43 // 50 //
(...skipping 27 matching lines...) Expand all
71 78
72 virtual Stats GetStats() const = 0; 79 virtual Stats GetStats() const = 0;
73 80
74 protected: 81 protected:
75 virtual ~FlexfecReceiveStream() = default; 82 virtual ~FlexfecReceiveStream() = default;
76 }; 83 };
77 84
78 } // namespace webrtc 85 } // namespace webrtc
79 86
80 #endif // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_H_ 87 #endif // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698