Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: webrtc/call/flexfec_receive_stream.h

Issue 2589713003: Make |rtcp_send_transport| mandatory in FlexfecReceiveStream::Config. (Closed)
Patch Set: Rebase. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 class FlexfecReceiveStream { 22 class FlexfecReceiveStream {
23 public: 23 public:
24 struct Stats { 24 struct Stats {
25 std::string ToString(int64_t time_ms) const; 25 std::string ToString(int64_t time_ms) const;
26 26
27 // TODO(brandtr): Add appropriate stats here. 27 // TODO(brandtr): Add appropriate stats here.
28 int flexfec_bitrate_bps; 28 int flexfec_bitrate_bps;
29 }; 29 };
30 30
31 struct Config { 31 struct Config {
32 Config() = delete;
philipel 2016/12/20 12:09:18 Default ctors are automatically removed if you imp
brandtr 2016/12/20 12:22:11 Removed.
33 explicit Config(Transport* rtcp_send_transport)
34 : rtcp_send_transport(rtcp_send_transport) {}
35
32 std::string ToString() const; 36 std::string ToString() const;
33 37
38 // Returns true if all RTP information is available in order to
39 // enable receiving FlexFEC.
40 bool IsCompleteAndEnabled() const;
41
34 // Payload type for FlexFEC. 42 // Payload type for FlexFEC.
35 int payload_type = -1; 43 int payload_type = -1;
36 44
37 // SSRC for FlexFEC stream to be received. 45 // SSRC for FlexFEC stream to be received.
38 uint32_t remote_ssrc = 0; 46 uint32_t remote_ssrc = 0;
39 47
40 // Vector containing a single element, corresponding to the SSRC of the 48 // Vector containing a single element, corresponding to the SSRC of the
41 // media stream being protected by this FlexFEC stream. The vector MUST have 49 // media stream being protected by this FlexFEC stream. The vector MUST have
42 // size 1. 50 // size 1.
43 // 51 //
(...skipping 27 matching lines...) Expand all
71 79
72 virtual Stats GetStats() const = 0; 80 virtual Stats GetStats() const = 0;
73 81
74 protected: 82 protected:
75 virtual ~FlexfecReceiveStream() = default; 83 virtual ~FlexfecReceiveStream() = default;
76 }; 84 };
77 85
78 } // namespace webrtc 86 } // namespace webrtc
79 87
80 #endif // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_H_ 88 #endif // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698