Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: webrtc/modules/rtp_rtcp/include/flexfec_receiver.h

Issue 2589583004: Add GUARDED_BY's in FlexfecReceiver. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
diff --git a/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h b/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
index dc90f045d58c2d864034a76da32e81e62bb27aa5..721d6c592fd7151f26de28f87d64f1844899d951 100644
--- a/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
+++ b/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
@@ -57,15 +57,18 @@ class FlexfecReceiver {
const uint32_t protected_media_ssrc_;
// Erasure code interfacing and callback.
- std::unique_ptr<ForwardErrorCorrection> erasure_code_;
- ForwardErrorCorrection::ReceivedPacketList received_packets_;
- ForwardErrorCorrection::RecoveredPacketList recovered_packets_;
- RecoveredPacketReceiver* const callback_;
+ std::unique_ptr<ForwardErrorCorrection> erasure_code_
+ GUARDED_BY(sequence_checker_);
+ ForwardErrorCorrection::ReceivedPacketList received_packets_
+ GUARDED_BY(sequence_checker_);
+ ForwardErrorCorrection::RecoveredPacketList recovered_packets_
+ GUARDED_BY(sequence_checker_);
+ RecoveredPacketReceiver* const callback_ GUARDED_BY(sequence_checker_);
// Logging and stats.
Clock* const clock_;
- int64_t last_recovered_packet_ms_;
- FecPacketCounter packet_counter_;
+ int64_t last_recovered_packet_ms_ GUARDED_BY(sequence_checker_);
+ FecPacketCounter packet_counter_ GUARDED_BY(sequence_checker_);
rtc::SequencedTaskChecker sequence_checker_;
};
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698