Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2588373005: RTC[In/Out]boundRTPStreamStats: qpSum,framesDecoded,framesEncoded added. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 429f93b755989a68793dcb46145ee586ebce422c..03caf99c5b0129769c2c202d7999a9a6b8efda16 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -307,6 +307,9 @@ class RTCRTPStreamStats : public RTCStats {
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854
// SLI count is only defined for |media_type == "video"|.
RTCStatsMember<uint32_t> sli_count;
+ // TODO(hbos): Only collected for the outbound case, should also be collected
+ // for inbound case by |RTCStatsCollector|. crbug.com/657854, crbug.com/657855
+ RTCStatsMember<uint64_t> qp_sum;
protected:
RTCRTPStreamStats(const std::string& id, int64_t timestamp_us);
@@ -352,6 +355,7 @@ class RTCInboundRTPStreamStats final : public RTCRTPStreamStats {
RTCStatsMember<double> gap_loss_rate;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
RTCStatsMember<double> gap_discard_rate;
+ RTCStatsMember<uint32_t> frames_decoded;
};
// https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
@@ -371,6 +375,7 @@ class RTCOutboundRTPStreamStats final : public RTCRTPStreamStats {
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657856
RTCStatsMember<double> target_bitrate;
RTCStatsMember<double> round_trip_time;
+ RTCStatsMember<uint32_t> frames_encoded;
};
// https://w3c.github.io/webrtc-stats/#transportstats-dict*

Powered by Google App Engine
This is Rietveld 408576698