Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: webrtc/api/test/mockpeerconnectionobservers.h

Issue 2584553002: New method StatsObserver::OnCompleteReports, passing ownership. (Closed)
Patch Set: Drop unneeded ".get()". Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/peerconnectioninterface.h ('k') | webrtc/sdk/android/src/jni/peerconnection_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/test/mockpeerconnectionobservers.h
diff --git a/webrtc/api/test/mockpeerconnectionobservers.h b/webrtc/api/test/mockpeerconnectionobservers.h
index 23647f6de3b5cbf3d5c8e6fda845103c77a04441..2bf0a3a83f7a4ace13c313fac13fa0f59cde5b4f 100644
--- a/webrtc/api/test/mockpeerconnectionobservers.h
+++ b/webrtc/api/test/mockpeerconnectionobservers.h
@@ -108,12 +108,12 @@ class MockStatsObserver : public webrtc::StatsObserver {
MockStatsObserver() : called_(false), stats_() {}
virtual ~MockStatsObserver() {}
- virtual void OnComplete(const StatsReports& reports) {
+ void OnCompleteReports(std::unique_ptr<StatsReports> reports) override {
ASSERT(!called_);
called_ = true;
stats_.Clear();
- stats_.number_of_reports = reports.size();
- for (const auto* r : reports) {
+ stats_.number_of_reports = reports->size();
+ for (const auto* r : *reports) {
if (r->type() == StatsReport::kStatsReportTypeSsrc) {
stats_.timestamp = r->timestamp();
GetIntValue(r, StatsReport::kStatsValueNameAudioOutputLevel,
« no previous file with comments | « webrtc/api/peerconnectioninterface.h ('k') | webrtc/sdk/android/src/jni/peerconnection_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698