Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Side by Side Diff: webrtc/api/peerconnection.cc

Issue 2584553002: New method StatsObserver::OnCompleteReports, passing ownership. (Closed)
Patch Set: Drop unneeded ".get()". Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1423 matching lines...) Expand 10 before | Expand all | Expand 10 after
1434 } 1434 }
1435 case MSG_CREATE_SESSIONDESCRIPTION_FAILED: { 1435 case MSG_CREATE_SESSIONDESCRIPTION_FAILED: {
1436 CreateSessionDescriptionMsg* param = 1436 CreateSessionDescriptionMsg* param =
1437 static_cast<CreateSessionDescriptionMsg*>(msg->pdata); 1437 static_cast<CreateSessionDescriptionMsg*>(msg->pdata);
1438 param->observer->OnFailure(param->error); 1438 param->observer->OnFailure(param->error);
1439 delete param; 1439 delete param;
1440 break; 1440 break;
1441 } 1441 }
1442 case MSG_GETSTATS: { 1442 case MSG_GETSTATS: {
1443 GetStatsMsg* param = static_cast<GetStatsMsg*>(msg->pdata); 1443 GetStatsMsg* param = static_cast<GetStatsMsg*>(msg->pdata);
1444 StatsReports reports; 1444 std::unique_ptr<StatsReports> reports(new StatsReports);
1445 stats_->GetStats(param->track, &reports); 1445 stats_->GetStats(param->track, reports.get());
1446 param->observer->OnComplete(reports); 1446 param->observer->OnCompleteReports(std::move(reports));
1447 delete param; 1447 delete param;
1448 break; 1448 break;
1449 } 1449 }
1450 case MSG_FREE_DATACHANNELS: { 1450 case MSG_FREE_DATACHANNELS: {
1451 sctp_data_channels_to_free_.clear(); 1451 sctp_data_channels_to_free_.clear();
1452 break; 1452 break;
1453 } 1453 }
1454 default: 1454 default:
1455 RTC_DCHECK(false && "Not implemented"); 1455 RTC_DCHECK(false && "Not implemented");
1456 break; 1456 break;
(...skipping 943 matching lines...) Expand 10 before | Expand all | Expand 10 after
2400 2400
2401 bool PeerConnection::StartRtcEventLog_w(rtc::PlatformFile file, 2401 bool PeerConnection::StartRtcEventLog_w(rtc::PlatformFile file,
2402 int64_t max_size_bytes) { 2402 int64_t max_size_bytes) {
2403 return event_log_->StartLogging(file, max_size_bytes); 2403 return event_log_->StartLogging(file, max_size_bytes);
2404 } 2404 }
2405 2405
2406 void PeerConnection::StopRtcEventLog_w() { 2406 void PeerConnection::StopRtcEventLog_w() {
2407 event_log_->StopLogging(); 2407 event_log_->StopLogging();
2408 } 2408 }
2409 } // namespace webrtc 2409 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698