New method StatsObserver::OnCompleteReports, passing ownership.

webrtc/api/peerconnectioninterface.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 91 matching lines @@
   virtual MediaStreamTrackInterface* FindVideoTrack(
       const std::string& id) = 0;
 
  protected:
   // Dtor protected as objects shouldn't be deleted via this interface.
   ~StreamCollectionInterface() {}
 };
 
 class StatsObserver : public rtc::RefCountInterface {
  public:
-  virtual void OnComplete(const StatsReports& reports) = 0;
+  // TODO(nisse, hbos): Old version, not passing ownership. Should
+  // perhaps be deprecated, but since all of this is a legacy
+  // interface anyway, probably best to leave as is until this class
+  // can be deleted.
+  virtual void OnComplete(const StatsReports& reports) {}
+  virtual void OnCompleteReports(std::unique_ptr<StatsReports> reports) {
+    OnComplete(*reports.get());

[hbos, 2016/12/15 13:39:40]

nit: Just *reports works too

[nisse-webrtc, 2016/12/15 14:02:31]

Done.

+  }
 
  protected:
   virtual ~StatsObserver() {}
 };
 
 class MetricsObserverInterface : public rtc::RefCountInterface {
  public:
 
   // |type| is the type of the enum counter to be incremented. |counter|
   // is the particular counter in that type. |counter_max| is the next sequence
@@ skipping 705 matching lines @@
     cricket::WebRtcVideoEncoderFactory* encoder_factory,
     cricket::WebRtcVideoDecoderFactory* decoder_factory) {
   return CreatePeerConnectionFactory(
       worker_and_network_thread, worker_and_network_thread, signaling_thread,
       default_adm, encoder_factory, decoder_factory);
 }
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_PEERCONNECTIONINTERFACE_H_