Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Side by Side Diff: webrtc/modules/audio_processing/aec3/render_transfer_buffer.cc

Issue 2584493002: Added first layer of the echo canceller 3 functionality (Closed)
Patch Set: Restricted the AnalyzeRender access, added ability to add external reporting of echo failure, and o… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/modules/audio_processing/aec3/render_transfer_buffer.h"
12
13 #include <memory>
14
15 namespace webrtc {
16
17 RenderTransferBufferWriter::~RenderTransferBufferWriter() {}
hlundin-webrtc 2016/12/16 10:04:48 = default
peah-webrtc 2016/12/20 10:10:26 I have removed this class in the new patch. Done.
18
19 RenderTransferBuffer::RenderTransferBuffer(size_t num_bands,
20 size_t frame_length)
21 : queue_(kQueueSize,
22 std::vector<float>(num_bands * frame_length),
23 RenderQueueItemVerifier<float>(num_bands * frame_length)),
24 frame_(num_bands * frame_length, 0.f) {
25 queue_.Clear();
hlundin-webrtc 2016/12/16 10:04:47 What does Clear() do on top of the ctor?
peah-webrtc 2016/12/20 10:10:26 I have removed this class in the new patch. Done.
26 }
27
28 RenderTransferBuffer::~RenderTransferBuffer() {}
hlundin-webrtc 2016/12/16 10:04:48 = default
peah-webrtc 2016/12/20 10:10:26 I have removed this class in the new patch. Done.
29
30 bool RenderTransferBuffer::Insert(std::vector<float>* frame) {
31 return queue_.Insert(frame);
32 }
33
34 bool RenderTransferBuffer::Remove(std::vector<float>* frame) {
35 bool result = queue_.Remove(frame);
hlundin-webrtc 2016/12/16 10:04:47 Why the local storage in result?
peah-webrtc 2016/12/20 10:10:26 I have removed this class in the new patch. Done.
36 return result;
37 }
38
39 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698