Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2583193002: Removed RTCStatsCollector::ProducePartialResultsOnWorkerThread. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstatscollector_unittest.cc
diff --git a/webrtc/api/rtcstatscollector_unittest.cc b/webrtc/api/rtcstatscollector_unittest.cc
index 4be7491724010ec0ae85d396f57698f2fed42039..29732a2aa7a5518e1b2c9f08b0076ba3297e02b9 100644
--- a/webrtc/api/rtcstatscollector_unittest.cc
+++ b/webrtc/api/rtcstatscollector_unittest.cc
@@ -396,15 +396,12 @@ class FakeRTCStatsCollector : public RTCStatsCollector,
if (!delivered_report_)
return false;
EXPECT_EQ(produced_on_signaling_thread_, 1);
- EXPECT_EQ(produced_on_worker_thread_, 1);
EXPECT_EQ(produced_on_network_thread_, 1);
EXPECT_TRUE(delivered_report_->Get("SignalingThreadStats"));
- EXPECT_TRUE(delivered_report_->Get("WorkerThreadStats"));
EXPECT_TRUE(delivered_report_->Get("NetworkThreadStats"));
produced_on_signaling_thread_ = 0;
- produced_on_worker_thread_ = 0;
produced_on_network_thread_ = 0;
delivered_report_ = nullptr;
return true;
@@ -434,20 +431,6 @@ class FakeRTCStatsCollector : public RTCStatsCollector,
new RTCTestStats("SignalingThreadStats", timestamp_us)));
AddPartialResults(signaling_report);
}
- void ProducePartialResultsOnWorkerThread(int64_t timestamp_us) override {
- EXPECT_TRUE(worker_thread_->IsCurrent());
- {
- rtc::CritScope cs(&lock_);
- EXPECT_FALSE(delivered_report_);
- ++produced_on_worker_thread_;
- }
-
- rtc::scoped_refptr<RTCStatsReport> worker_report =
- RTCStatsReport::Create(0);
- worker_report->AddStats(std::unique_ptr<const RTCStats>(
- new RTCTestStats("WorkerThreadStats", timestamp_us)));
- AddPartialResults(worker_report);
- }
void ProducePartialResultsOnNetworkThread(int64_t timestamp_us) override {
EXPECT_TRUE(network_thread_->IsCurrent());
{
@@ -471,7 +454,6 @@ class FakeRTCStatsCollector : public RTCStatsCollector,
rtc::CriticalSection lock_;
rtc::scoped_refptr<const RTCStatsReport> delivered_report_;
int produced_on_signaling_thread_ = 0;
- int produced_on_worker_thread_ = 0;
int produced_on_network_thread_ = 0;
};
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698