Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm

Issue 2581913002: Adding Java and Obj-C bindings for RtpEncodingParameters.ssrc. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm b/webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm
index af07a0485d64e92f57ddd00842264f0cb91e1b63..be47894a8fe18837bd3a67efaaa1966bbf1c9364 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm
@@ -14,6 +14,7 @@
@synthesize isActive = _isActive;
@synthesize maxBitrateBps = _maxBitrateBps;
+@synthesize ssrc = _ssrc;
static const int kBitrateUnlimited = -1;
@@ -30,6 +31,9 @@ static const int kBitrateUnlimited = -1;
_maxBitrateBps =
[NSNumber numberWithInt:nativeParameters.max_bitrate_bps];
}
+ if (nativeParameters.ssrc) {
+ _ssrc = [NSNumber numberWithUnsignedLong:*nativeParameters.ssrc];
tkchin_webrtc 2017/01/05 22:25:14 for my own knowledge - is int in C++ 32 or 64 bit?
Taylor Brandstetter 2017/01/05 22:47:27 Technically speaking, it's only guaranteed to be 1
tkchin_webrtc 2017/01/05 23:36:45 Ok. I just noticed this is a settable property, as
Taylor Brandstetter 2017/01/06 00:19:07 Actually, it's not meant to be settable in the fir
+ }
}
return self;
}
@@ -40,6 +44,9 @@ static const int kBitrateUnlimited = -1;
if (_maxBitrateBps != nil) {
parameters.max_bitrate_bps = _maxBitrateBps.intValue;
}
+ if (_ssrc != nil) {
+ parameters.ssrc = rtc::Optional<uint32_t>(_ssrc.unsignedLongValue);
+ }
return parameters;
}
« no previous file with comments | « webrtc/sdk/android/src/jni/peerconnection_jni.cc ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698