Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: webrtc/common_types.h

Issue 2580733004: Remove OverUseDetectorOptions from OveruseDetector since it isn't used. (Closed)
Patch Set: Update comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 } 690 }
691 691
692 private: 692 private:
693 uint32_t sum_; 693 uint32_t sum_;
694 uint32_t bitrates_[kMaxSpatialLayers][kMaxTemporalStreams]; 694 uint32_t bitrates_[kMaxSpatialLayers][kMaxTemporalStreams];
695 }; 695 };
696 696
697 // Bandwidth over-use detector options. These are used to drive 697 // Bandwidth over-use detector options. These are used to drive
698 // experimentation with bandwidth estimation parameters. 698 // experimentation with bandwidth estimation parameters.
699 // See modules/remote_bitrate_estimator/overuse_detector.h 699 // See modules/remote_bitrate_estimator/overuse_detector.h
700 // TODO(terelius): This is only used in overuse_estimator.cc, and only in the
701 // default constructed state. Can we move the relevant variables into that
702 // class and delete this? See also disabled warning at line 27
stefan-webrtc 2016/12/22 09:37:25 I would be happy to get rid of this struct. I've b
700 struct OverUseDetectorOptions { 703 struct OverUseDetectorOptions {
701 OverUseDetectorOptions() 704 OverUseDetectorOptions()
702 : initial_slope(8.0 / 512.0), 705 : initial_slope(8.0 / 512.0),
703 initial_offset(0), 706 initial_offset(0),
704 initial_e(), 707 initial_e(),
705 initial_process_noise(), 708 initial_process_noise(),
706 initial_avg_noise(0.0), 709 initial_avg_noise(0.0),
707 initial_var_noise(50) { 710 initial_var_noise(50) {
708 initial_e[0][0] = 100; 711 initial_e[0][0] = 100;
709 initial_e[1][1] = 1e-1; 712 initial_e[1][1] = 1e-1;
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 enum class RtcpMode { kOff, kCompound, kReducedSize }; 896 enum class RtcpMode { kOff, kCompound, kReducedSize };
894 897
895 enum NetworkState { 898 enum NetworkState {
896 kNetworkUp, 899 kNetworkUp,
897 kNetworkDown, 900 kNetworkDown,
898 }; 901 };
899 902
900 } // namespace webrtc 903 } // namespace webrtc
901 904
902 #endif // WEBRTC_COMMON_TYPES_H_ 905 #endif // WEBRTC_COMMON_TYPES_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698