Add TransportFeedbackPacketLossTracker.

webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TRANSPORT_FEEDBACK_H_
 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TRANSPORT_FEEDBACK_H_
 
 #include <deque>
 #include <memory>
 #include <vector>
 
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/deprecation.h"
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h"
 
 namespace webrtc {
 namespace rtcp {
+
+class TransportFeedbackInterface {
+ public:
+  virtual ~TransportFeedbackInterface() = default;
+  enum class StatusSymbol {
+    kNotReceived,
+    kReceivedSmallDelta,
+    kReceivedLargeDelta,
+  };
+  virtual void SetBase(uint16_t base_sequence, int64_t ref_timestamp_us) = 0;
+  virtual void SetFeedbackSequenceNumber(uint8_t feedback_sequence) = 0;
+  virtual bool AddReceivedPacket(uint16_t sequence_number,
+                                 int64_t timestamp_us) = 0;
+  virtual uint16_t GetBaseSequence() const = 0;
+  virtual std::vector<StatusSymbol> GetStatusVector() const = 0;
+  virtual std::vector<int16_t> GetReceiveDeltas() const = 0;
+  virtual int64_t GetBaseTimeUs() const = 0;
+  virtual std::vector<int64_t> GetReceiveDeltasUs() const = 0;
+};
+
 class CommonHeader;
 
-class TransportFeedback : public Rtpfb {
+class TransportFeedback : public Rtpfb, public TransportFeedbackInterface {

[kwiberg-webrtc, 2017/01/05 02:51:12]

Can this class be final now?

[minyue-webrtc, 2017/01/19 10:57:55]

sorry, I wanted to make it that way but PacketCounter (test code) makes it hard,
see
https://cs.chromium.org/chromium/src/third_party/webrtc/test/rtcp_packet_pars...

Fixing PacketCounter may be a bit out-reached. but can be a follow-up.

I add a TODO here.

  public:
   class PacketStatusChunk;
   // TODO(sprang): IANA reg?
   static constexpr uint8_t kFeedbackMessageType = 15;
   // Convert to multiples of 0.25ms.
   static constexpr int kDeltaScaleFactor = 250;
 
   TransportFeedback();
   ~TransportFeedback() override;
 
-  void SetBase(uint16_t base_sequence,     // Seq# of first packet in this msg.
-               int64_t ref_timestamp_us);  // Reference timestamp for this msg.
-  void SetFeedbackSequenceNumber(uint8_t feedback_sequence);
+  void SetBase(uint16_t base_sequence,    // Seq# of first packet in this msg.
+               int64_t ref_timestamp_us)  // Reference timestamp for this msg.
+      override;
+  void SetFeedbackSequenceNumber(uint8_t feedback_sequence) override;
   // NOTE: This method requires increasing sequence numbers (excepting wraps).
-  bool AddReceivedPacket(uint16_t sequence_number, int64_t timestamp_us);
+  bool AddReceivedPacket(uint16_t sequence_number,
+                         int64_t timestamp_us) override;
 
-  enum class StatusSymbol {
-    kNotReceived,
-    kReceivedSmallDelta,
-    kReceivedLargeDelta,
-  };
-
-  uint16_t GetBaseSequence() const;
-  std::vector<TransportFeedback::StatusSymbol> GetStatusVector() const;
-  std::vector<int16_t> GetReceiveDeltas() const;
+  uint16_t GetBaseSequence() const override;
+  std::vector<StatusSymbol> GetStatusVector() const override;
+  std::vector<int16_t> GetReceiveDeltas() const override;
 
   // Get the reference time in microseconds, including any precision loss.
-  int64_t GetBaseTimeUs() const;
+  int64_t GetBaseTimeUs() const override;
   // Convenience method for getting all deltas as microseconds. The first delta
   // is relative the base time.
-  std::vector<int64_t> GetReceiveDeltasUs() const;
+  std::vector<int64_t> GetReceiveDeltasUs() const override;
 
   bool Parse(const CommonHeader& packet);
   static std::unique_ptr<TransportFeedback> ParseFrom(const uint8_t* buffer,
                                                       size_t length);
 
   RTC_DEPRECATED
   void WithPacketSenderSsrc(uint32_t ssrc) { SetSenderSsrc(ssrc); }
   RTC_DEPRECATED
   void WithMediaSourceSsrc(uint32_t ssrc) { SetMediaSsrc(ssrc); }
   RTC_DEPRECATED
@@ skipping 42 matching lines @@
   uint16_t first_symbol_cardinality_;
   bool vec_needs_two_bit_symbols_;
   uint32_t size_bytes_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(TransportFeedback);
 };
 
 }  // namespace rtcp
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TRANSPORT_FEEDBACK_H_