Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: webrtc/modules/congestion_controller/trendline_estimator.h

Issue 2577463002: Avoid precision loss in TrendlineEstimator from int64_t -> double conversion (Closed)
Patch Set: Avoid precision loss in TrendlineFilter by passing the arrival time as an int64_t rather than a dou… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/trendline_estimator.h
diff --git a/webrtc/modules/congestion_controller/trendline_estimator.h b/webrtc/modules/congestion_controller/trendline_estimator.h
index 0bf9bf27c74ce05e9da6f4a8989fecb7ae4e5c91..6c3be223681f09d9e870500bdd781b1f1d80fdc5 100644
--- a/webrtc/modules/congestion_controller/trendline_estimator.h
+++ b/webrtc/modules/congestion_controller/trendline_estimator.h
@@ -33,7 +33,9 @@ class TrendlineEstimator {
// Update the estimator with a new sample. The deltas should represent deltas
// between timestamp groups as defined by the InterArrival class.
- void Update(double recv_delta_ms, double send_delta_ms, double now_ms);
+ void Update(double recv_delta_ms,
+ double send_delta_ms,
+ int64_t arrival_time_ms);
// Returns the estimated trend k multiplied by some gain.
// 0 < k < 1 -> the delay increases, queues are filling up
@@ -51,6 +53,8 @@ class TrendlineEstimator {
const double threshold_gain_;
// Used by the existing threshold.
unsigned int num_of_deltas_;
+ // Keep the arival times small by using the change from the first packet.
brandtr 2016/12/14 09:12:38 "arrival"
terelius 2016/12/14 14:22:32 Done.
+ int64_t first_arrival_time_ms;
// Exponential backoff filtering.
double accumulated_delay_;
double smoothed_delay_;

Powered by Google App Engine
This is Rietveld 408576698