Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc

Issue 2576653002: Disable AudioDeviceTest.StartPlayoutOnTwoInstances on iOS (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 EXPECT_EQ(0, audio_device()->StartPlayout()); 613 EXPECT_EQ(0, audio_device()->StartPlayout());
614 EXPECT_EQ(0, audio_device()->StopPlayout()); 614 EXPECT_EQ(0, audio_device()->StopPlayout());
615 EXPECT_FALSE(audio_device()->PlayoutIsInitialized()); 615 EXPECT_FALSE(audio_device()->PlayoutIsInitialized());
616 } 616 }
617 617
618 // Verify that we can create two ADMs and start playing on the second ADM. 618 // Verify that we can create two ADMs and start playing on the second ADM.
619 // Only the first active instance shall activate an audio session and the 619 // Only the first active instance shall activate an audio session and the
620 // last active instance shall deactivate the audio session. The test does not 620 // last active instance shall deactivate the audio session. The test does not
621 // explicitly verify correct audio session calls but instead focuses on 621 // explicitly verify correct audio session calls but instead focuses on
622 // ensuring that audio starts for both ADMs. 622 // ensuring that audio starts for both ADMs.
623 TEST_F(AudioDeviceTest, StartPlayoutOnTwoInstances) { 623
624 // Failing when running on real iOS devices: bugs.webrtc.org/6889.
625 TEST_F(AudioDeviceTest, DISABLED_StartPlayoutOnTwoInstances) {
624 // Create and initialize a second/extra ADM instance. The default ADM is 626 // Create and initialize a second/extra ADM instance. The default ADM is
625 // created by the test harness. 627 // created by the test harness.
626 rtc::scoped_refptr<AudioDeviceModule> second_audio_device = 628 rtc::scoped_refptr<AudioDeviceModule> second_audio_device =
627 CreateAudioDevice(AudioDeviceModule::kPlatformDefaultAudio); 629 CreateAudioDevice(AudioDeviceModule::kPlatformDefaultAudio);
628 EXPECT_NE(second_audio_device.get(), nullptr); 630 EXPECT_NE(second_audio_device.get(), nullptr);
629 EXPECT_EQ(0, second_audio_device->Init()); 631 EXPECT_EQ(0, second_audio_device->Init());
630 632
631 // Start playout for the default ADM but don't wait here. Instead use the 633 // Start playout for the default ADM but don't wait here. Instead use the
632 // upcoming second stream for that. We set the same expectation on number 634 // upcoming second stream for that. We set the same expectation on number
633 // of callbacks as for the second stream. 635 // of callbacks as for the second stream.
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 StopPlayout(); 815 StopPlayout();
814 StopRecording(); 816 StopRecording();
815 // Verify that the correct number of transmitted impulses are detected. 817 // Verify that the correct number of transmitted impulses are detected.
816 EXPECT_EQ(latency_audio_stream->num_latency_values(), 818 EXPECT_EQ(latency_audio_stream->num_latency_values(),
817 static_cast<size_t>( 819 static_cast<size_t>(
818 kImpulseFrequencyInHz * kMeasureLatencyTimeInSec - 1)); 820 kImpulseFrequencyInHz * kMeasureLatencyTimeInSec - 1));
819 latency_audio_stream->PrintResults(); 821 latency_audio_stream->PrintResults();
820 } 822 }
821 823
822 } // namespace webrtc 824 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698