Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: src/builtins/builtins.cc

Issue 2573573004: [stubs] Enable graph verification for builtins. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-array.cc » ('j') | src/compiler/machine-graph-verifier.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/code-events.h" 6 #include "src/code-events.h"
7 #include "src/compiler/code-assembler.h" 7 #include "src/compiler/code-assembler.h"
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 #include "src/isolate.h" 10 #include "src/isolate.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 Code* BuildWithCodeStubAssemblerJS(Isolate* isolate, 82 Code* BuildWithCodeStubAssemblerJS(Isolate* isolate,
83 CodeAssemblerGenerator generator, int argc, 83 CodeAssemblerGenerator generator, int argc,
84 Code::Flags flags, const char* name) { 84 Code::Flags flags, const char* name) {
85 HandleScope scope(isolate); 85 HandleScope scope(isolate);
86 Zone zone(isolate->allocator(), ZONE_NAME); 86 Zone zone(isolate->allocator(), ZONE_NAME);
87 const int argc_with_recv = 87 const int argc_with_recv =
88 (argc == SharedFunctionInfo::kDontAdaptArgumentsSentinel) ? 0 : argc + 1; 88 (argc == SharedFunctionInfo::kDontAdaptArgumentsSentinel) ? 0 : argc + 1;
89 compiler::CodeAssemblerState state(isolate, &zone, argc_with_recv, flags, 89 compiler::CodeAssemblerState state(isolate, &zone, argc_with_recv, flags,
90 name); 90 name);
91 generator(&state); 91 generator(&state);
92 Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state); 92 Handle<Code> code =
93 compiler::CodeAssembler::GenerateCode(&state, FLAG_csa_verify);
93 PostBuildProfileAndTracing(isolate, *code, name); 94 PostBuildProfileAndTracing(isolate, *code, name);
94 return *code; 95 return *code;
95 } 96 }
96 97
97 // Builder for builtins implemented in TurboFan with CallStub linkage. 98 // Builder for builtins implemented in TurboFan with CallStub linkage.
98 Code* BuildWithCodeStubAssemblerCS(Isolate* isolate, 99 Code* BuildWithCodeStubAssemblerCS(Isolate* isolate,
99 CodeAssemblerGenerator generator, 100 CodeAssemblerGenerator generator,
100 CallDescriptors::Key interface_descriptor, 101 CallDescriptors::Key interface_descriptor,
101 Code::Flags flags, const char* name) { 102 Code::Flags flags, const char* name) {
102 HandleScope scope(isolate); 103 HandleScope scope(isolate);
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 // TODO(jochen): Remove this. 291 // TODO(jochen): Remove this.
291 if (responsible_context.is_null()) { 292 if (responsible_context.is_null()) {
292 return true; 293 return true;
293 } 294 }
294 if (*responsible_context == target->context()) return true; 295 if (*responsible_context == target->context()) return true;
295 return isolate->MayAccess(responsible_context, target_global_proxy); 296 return isolate->MayAccess(responsible_context, target_global_proxy);
296 } 297 }
297 298
298 } // namespace internal 299 } // namespace internal
299 } // namespace v8 300 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins-array.cc » ('j') | src/compiler/machine-graph-verifier.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698