ParseCandidate(): Refactor to fix memcheck false positive.

webrtc/api/webrtcsdp.cc

 /*
  *  Copyright 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 1016 matching lines @@
     return false;
   }
   const std::string& connection_address = fields[4];
   int port = 0;
   if (!GetValueFromString(first_line, fields[5], &port, error)) {
     return false;
   }
   SocketAddress address(connection_address, port);
 
   cricket::ProtocolType protocol;
-  if (!StringToProto(transport.c_str(), &protocol) ||
-      protocol == cricket::PROTO_TLS) {
+  if (!StringToProto(transport.c_str(), &protocol)) {
     return ParseFailed(first_line, "Unsupported transport type.", error);
   }
+  switch (protocol) {
+    case cricket::PROTO_UDP:
+    case cricket::PROTO_TCP:
+    case cricket::PROTO_SSLTCP:
+      // Supported protocol.
+      break;
+    default:
+      return ParseFailed(first_line, "Unsupported transport type.", error);
+  }
 
   std::string candidate_type;
   const std::string& type = fields[7];
   if (type == kCandidateHost) {
     candidate_type = cricket::LOCAL_PORT_TYPE;
   } else if (type == kCandidateSrflx) {
     candidate_type = cricket::STUN_PORT_TYPE;
   } else if (type == kCandidateRelay) {
     candidate_type = cricket::RELAY_PORT_TYPE;
   } else if (type == kCandidatePrflx) {
@@ skipping 2160 matching lines @@
     UpdateCodec<AudioContentDescription, cricket::AudioCodec>(
         media_desc, payload_type, feedback_param);
   } else if (media_type == cricket::MEDIA_TYPE_VIDEO) {
     UpdateCodec<VideoContentDescription, cricket::VideoCodec>(
         media_desc, payload_type, feedback_param);
   }
   return true;
 }
 
 }  // namespace webrtc