Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2569353004: [stubs] Enable machine graph verification for fast accessor assembler. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Enable machine graph verification for fast accessor assembler. ... and clean it up. BUG= Committed: https://crrev.com/33480daa60b1f7107a1f71407b6d07b59970d304 Cr-Commit-Position: refs/heads/master@{#41694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -68 lines) Patch
M src/fast-accessor-assembler.h View 3 chunks +8 lines, -7 lines 0 comments Download
M src/fast-accessor-assembler.cc View 10 chunks +55 lines, -61 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-14 10:17:10 UTC) #9
epertoso
lgtm
4 years ago (2016-12-14 13:31:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569353004/40001
4 years ago (2016-12-14 13:35:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-14 13:37:31 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-14 13:37:44 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33480daa60b1f7107a1f71407b6d07b59970d304
Cr-Commit-Position: refs/heads/master@{#41694}

Powered by Google App Engine
This is Rietveld 408576698