Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

Issue 2568743007: Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 } 696 }
697 697
698 // VP9: Run with no packet loss, with an update (decrease) in frame rate. 698 // VP9: Run with no packet loss, with an update (decrease) in frame rate.
699 // Lower frame rate means higher per-frame-bandwidth, so easier to encode. 699 // Lower frame rate means higher per-frame-bandwidth, so easier to encode.
700 // At the low bitrate in this test, this means better rate control after the 700 // At the low bitrate in this test, this means better rate control after the
701 // update(s) to lower frame rate. So expect less frame drops, and max values 701 // update(s) to lower frame rate. So expect less frame drops, and max values
702 // for the rate control metrics can be lower. One key frame (first frame only). 702 // for the rate control metrics can be lower. One key frame (first frame only).
703 // Note: quality after update should be higher but we currently compute quality 703 // Note: quality after update should be higher but we currently compute quality
704 // metrics averaged over whole sequence run. 704 // metrics averaged over whole sequence run.
705 705
706 #if defined(WEBRTC_ANDROID) 706
707 // Flaky on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=6057. 707 // Flaky https://bugs.chromium.org/p/webrtc/issues/detail?id=6057.
708 #define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP9 \
709 DISABLED_ProcessNoLossChangeFrameRateFrameDropVP9
710 #else
711 #define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP9 \
712 ProcessNoLossChangeFrameRateFrameDropVP9
713 #endif
714 TEST_F(VideoProcessorIntegrationTest, 708 TEST_F(VideoProcessorIntegrationTest,
715 MAYBE_ProcessNoLossChangeFrameRateFrameDropVP9) { 709 DISABLED_ProcessNoLossChangeFrameRateFrameDropVP9) {
716 config_.networking_config.packet_loss_probability = 0; 710 config_.networking_config.packet_loss_probability = 0;
717 // Bitrate and frame rate profile. 711 // Bitrate and frame rate profile.
718 RateProfile rate_profile; 712 RateProfile rate_profile;
719 SetRateProfilePars(&rate_profile, 0, 100, 24, 0); 713 SetRateProfilePars(&rate_profile, 0, 100, 24, 0);
720 SetRateProfilePars(&rate_profile, 1, 100, 15, 100); 714 SetRateProfilePars(&rate_profile, 1, 100, 15, 100);
721 SetRateProfilePars(&rate_profile, 2, 100, 10, 200); 715 SetRateProfilePars(&rate_profile, 2, 100, 10, 200);
722 rate_profile.frame_index_rate_update[3] = kNbrFramesLong + 1; 716 rate_profile.frame_index_rate_update[3] = kNbrFramesLong + 1;
723 rate_profile.num_frames = kNbrFramesLong; 717 rate_profile.num_frames = kNbrFramesLong;
724 // Codec/network settings. 718 // Codec/network settings.
725 CodecConfigPars process_settings; 719 CodecConfigPars process_settings;
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 QualityMetrics quality_metrics; 964 QualityMetrics quality_metrics;
971 SetQualityMetrics(&quality_metrics, 32.5, 30.0, 0.85, 0.80); 965 SetQualityMetrics(&quality_metrics, 32.5, 30.0, 0.85, 0.80);
972 // Metrics for rate control. 966 // Metrics for rate control.
973 RateControlMetrics rc_metrics[2]; 967 RateControlMetrics rc_metrics[2];
974 SetRateControlMetrics(rc_metrics, 0, 0, 20, 30, 10, 10, 0, 1); 968 SetRateControlMetrics(rc_metrics, 0, 0, 20, 30, 10, 10, 0, 1);
975 SetRateControlMetrics(rc_metrics, 1, 0, 0, 30, 15, 10, 0, 0); 969 SetRateControlMetrics(rc_metrics, 1, 0, 0, 30, 15, 10, 0, 0);
976 ProcessFramesAndVerify(quality_metrics, rate_profile, process_settings, 970 ProcessFramesAndVerify(quality_metrics, rate_profile, process_settings,
977 rc_metrics); 971 rc_metrics);
978 } 972 }
979 } // namespace webrtc 973 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698