Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2568013002: Change MANUAL -> DISABLED for ScreenCapturerIntegrationTest tests (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
Hzj_jie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change MANUAL -> DISABLED for ScreenCapturerIntegrationTest tests It turns out MANUAL_ isn't a part of the supported gtest prefixes: it's a part of the Chromium test launcher: https://cs.chromium.org/chromium/src/content/public/test/test_launcher.cc?rcl=0&l=69 Luckily, we can use DISABLED_ for the same purpose, since there's the --gtest_also_run_disabled_tests flag we can use. BUG=webrtc:6666, webrtc:6843 TBR=zijiehe@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/99f7bfde283b8ae20971b9bd804c6210f7c156eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_integration_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99f7bfde283b8ae20971b9bd804c6210f7c156eb Cr-Commit-Position: refs/heads/master@{#15539}
4 years ago (2016-12-12 07:30:14 UTC) #3
kjellander_webrtc
4 years ago (2016-12-12 07:30:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99f7bfde283b8ae20971b9bd804c6210f7c156eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698