Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2567513003: Added basic framework for AEC3 in the audio processing module (Closed)
Patch Set: Changes in response to reviewer comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index d03c7f4ab4f336189a335f0740ab358808ddf7f6..d1a711dfa6a3d38f02d87622ee07849c5db43f85 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -68,17 +68,6 @@ struct ExtendedFilter {
bool enabled;
};
-// Enables the next generation AEC functionality. This feature replaces the
-// standard methods for echo removal in the AEC. This configuration only applies
-// to EchoCancellation and not EchoControlMobile. It can be set in the
-// constructor or using AudioProcessing::SetExtraOptions().
-struct EchoCanceller3 {
- EchoCanceller3() : enabled(false) {}
- explicit EchoCanceller3(bool enabled) : enabled(enabled) {}
- static const ConfigOptionID identifier = ConfigOptionID::kEchoCanceller3;
- bool enabled;
-};
-
// Enables the refined linear filter adaptation in the echo canceller.
// This configuration only applies to EchoCancellation and not
// EchoControlMobile. It can be set in the constructor
@@ -274,6 +263,14 @@ class AudioProcessing {
struct HighPassFilter {
bool enabled = false;
} high_pass_filter;
+
+ // Enables the next generation AEC functionality. This feature replaces the
+ // standard methods for echo removal in the AEC.
+ // The functionality is not yet activated in the code and turning this on
+ // does not yet have the desired behavior.
+ struct EchoCanceller3 {
+ bool enabled = false;
+ } echo_canceller3;
};
// TODO(mgraczyk): Remove once all methods that use ChannelLayout are gone.
« no previous file with comments | « webrtc/modules/audio_processing/echo_cancellation_impl.cc ('k') | webrtc/modules/audio_processing/include/config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698