Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2567513003: Added basic framework for AEC3 in the audio processing module (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index d03c7f4ab4f336189a335f0740ab358808ddf7f6..10f9d2e7489f0b4ff4f3e5ea771dd407130276ab 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -68,17 +68,6 @@ struct ExtendedFilter {
bool enabled;
};
-// Enables the next generation AEC functionality. This feature replaces the
-// standard methods for echo removal in the AEC. This configuration only applies
-// to EchoCancellation and not EchoControlMobile. It can be set in the
-// constructor or using AudioProcessing::SetExtraOptions().
-struct EchoCanceller3 {
- EchoCanceller3() : enabled(false) {}
- explicit EchoCanceller3(bool enabled) : enabled(enabled) {}
- static const ConfigOptionID identifier = ConfigOptionID::kEchoCanceller3;
- bool enabled;
-};
-
// Enables the refined linear filter adaptation in the echo canceller.
// This configuration only applies to EchoCancellation and not
// EchoControlMobile. It can be set in the constructor
@@ -274,6 +263,10 @@ class AudioProcessing {
struct HighPassFilter {
bool enabled = false;
} high_pass_filter;
+
+ struct EchoCanceller3 {
+ bool enabled = false;
+ } echo_canceller3;
};
aleloi 2016/12/09 13:30:04 Should webrtc::ConfigOptionID::kEchoCanceller3 be
peah-webrtc 2016/12/12 19:46:46 Good point! I added that as well. Done.
// TODO(mgraczyk): Remove once all methods that use ChannelLayout are gone.

Powered by Google App Engine
This is Rietveld 408576698